Update the Portlet Container to use the Container API

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: None
• Fix Version/s: 5.1.0
• Component/s: None
• Labels: None
• Similar Issues: Show 5 results ; ;

  LEP-6526	PortletWindowContextImpl and WindowInvoker needs to updated due to changes in Container API
  LEP-7575	Sample Search Container Portlet
  LEP-1191	Unable to remove portlets whose name contains spaces
  LEP-3185	Friendly URL must not contain uppercase characters if virtual host is used for a community
  LEP-279	When passing a parameter containing a non-ascii character using the portlet:param tag the non-ascii characters are corrupted.

The Portlet Container should be updated to use the Container API based on the document.(https://portlet-container.dev.java.net/docs/EmbeddingPC.html)

[Deepak Gothe]

The changes have been committed, revision 17205.

[Brian Chan]

Hi Deepak,

Thanks for the changes.

I've commited my first review which has to do with modified classes, the second review will be with newly added classes that I'll check in later today after some more tests.

Here's a list of items for the first review, please see commit 17213 and do a diff so you can see each line that was modified. Thanks!

1.) web.xml spacing was off

2.) versions.xml was not ordered properly and had incorrect paths for jars

3.) nbproject\project.xml was not ordered properly

4.) .classpath for eclipse is broken

5.) PortletRequestImpl.java had modifications that did nothing, incorrect ordering of methods

6.) PortletImpl.java doesn't need getPortletWebAppName, PortletImpl.getPortletApp().getServletContextName() gives the same info

7.) I also added a property so that we can switch to the older implementation (for backwards compatibility)

That's just a few, but an actual diff will show you everything. Thanks!

[Brian Chan]

Hi Deepak,

Please check out my revisions in 17238 as I did a bit of code clean up and consolidation.

Specifically in ContainerRequestFactory.java, WindowInvoker.java, and InvokerPortlet.java.

[Deepak Gothe]

I checked the diffs. Thanks for the code clean up and consolidation. There was minor issue in PortletWindowRequestReader. I have committed the fix..please see revision 17242.