[#LEP-6441] Update the Portlet Container to use the Container API

PUBLIC - Old Liferay Portal (Use Liferay Portal Standard Edition)

Update the Portlet Container to use the Container API

Created: 26/Jun/08 09:56 AM Updated: 27/Jun/08 05:47 AM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

5.1.0

Time Tracking:

Original Estimate:

2 days

Remaining Estimate:

2 days

Time Spent:

Not Specified

Description

« Hide

The Portlet Container should be updated to use the Container API based on the document.(https://portlet-container.dev.java.net/docs/EmbeddingPC.html)

All

Comments

Work Log

Change History

FishEye

Sort Order:

[ Permalink | « Hide ]

Deepak Gothe added a comment - 26/Jun/08 10:42 AM

The changes have been committed, revision 17205.

[ Permalink | « Hide ]

Brian Chan added a comment - 26/Jun/08 12:15 PM - Visible to

Hi Deepak,

Thanks for the changes.

I've commited my first review which has to do with modified classes, the second review will be with newly added classes that I'll check in later today after some more tests.

Here's a list of items for the first review, please see commit 17213 and do a diff so you can see each line that was modified. Thanks!

1.) web.xml spacing was off

2.) versions.xml was not ordered properly and had incorrect paths for jars

3.) nbproject\project.xml was not ordered properly

4.) .classpath for eclipse is broken

5.) PortletRequestImpl.java had modifications that did nothing, incorrect ordering of methods

6.) PortletImpl.java doesn't need getPortletWebAppName, PortletImpl.getPortletApp().getServletContextName() gives the same info

7.) I also added a property so that we can switch to the older implementation (for backwards compatibility)

That's just a few, but an actual diff will show you everything. Thanks!

[ Permalink | « Hide ]

Brian Chan added a comment - 26/Jun/08 06:30 PM - Visible to

Hi Deepak,

Please check out my revisions in 17238 as I did a bit of code clean up and consolidation.

Specifically in ContainerRequestFactory.java, WindowInvoker.java, and InvokerPortlet.java.

[ Permalink | « Hide ]

Deepak Gothe added a comment - 27/Jun/08 05:47 AM

I checked the diffs. Thanks for the code clean up and consolidation. There was minor issue in PortletWindowRequestReader. I have committed the fix..please see revision 17242.