When editing a file in Document Library the extension of the new file must match the extension of the previous versions

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.0.2 RC
• Fix Version/s: 6.0.3 GA
• Component/s: DM > Document Library Display
• Labels: None
• Similar Issues: Show 5 results ; ;

  LPS-10979	When downloading a previous version of a document library file the name of the downloaded file is different
  LPS-11821	Document library portlet accepts different file extensions for document versioning
  LPS-19951	Document Library FileEntry extension not changing if a new version of the file has a different extension
  LPS-6314	Allow users to change extensions of DL file entry
  LPS-10980	Editing the name of a file in Document Library doesn't update the extension

User can add a file to Document Library. Then, he is allowed to edit that file and upload a new document of a different type (with different extension). For example, a user can add a .DOC file but then he is allowed to edit it and upload a .JPG file.
This ticket validates that the extension of the file to be uploaded must match the extension of the previous versions of the file.

[Sergio Gonzalez]

The commit also fixes a problem in DLLocalServiceImpl updateFile(): it was missing document size validation when validateFileExtension is false.

[James McGovern]

Extension should be of same family but not required to be exact. Consider Microsoft Word and things like .doc vs .docx

[Sergio Gonzalez]

Recommited.
Added the following property to portal.properties:

dl.file.extensions.check.strict=true

When this property is true, uploading files to edit a previously stored one, is only possible when both files have the same extension. When the property is false there is no need that both extension match, so the user can modify a file entry and upload any file he wants (no matter the extension)

[Brian Chan]

Renamed it to dl.file.extensions.strict.check=

[Brian Chan]

Hey Sergio,

I had to default it to false or else WebDAV breaks in OSX.

It tries to rename things from "tmp" to "docx" for this one test:

Go to portal-impl, run "ant test-class -Dclass=WebDAVTestSuite"

18:10:10,417 INFO [WebDAVServlet:136] OSX: (testMSOffice3Modify:277) GET /webdav/guest/document_library/WebDAVTest/._Test.docx 200

1. 1. fileExtension tmp
      18:10:10,417 WARN [DLWebDAVStorageImpl:699] com.liferay.documentlibrary.SourceFileNameException: docx
      com.liferay.documentlibrary.SourceFileNameException: docx
      at com.liferay.documentlibrary.service.impl.DLLocalServiceImpl.validate(DLLocalServiceImpl.java:313)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:592)
      at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:309)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
      at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:67)
      at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:60)
      at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:60)
      at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:60)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
      at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:89)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
      at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)
      at $Proxy148.validate(Unknown Source)
      at com.liferay.portlet.documentlibrary.service.impl.DLFileEntryLocalServiceImpl.validate(DLFileEntryLocalServiceImpl.java:1397)
      at com.liferay.portlet.documentlibrary.service.impl.DLFileEntryLocalServiceImpl.updateFileEntry(DLFileEntryLocalServiceImpl.java:966)
      at com.liferay.portlet.documentlibrary.service.impl.DLFileEntryLocalServiceImpl.updateFileEntry(DLFileEntryLocalServiceImpl.java:932)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:592)
      at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:309)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
      at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:67)
      at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:60)
      at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:60)
      at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:60)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
      at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:89)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
      at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)
      at $Proxy139.updateFileEntry(Unknown Source)
      at com.liferay.portlet.documentlibrary.service.impl.DLFileEntryServiceImpl.updateFileEntry(DLFileEntryServiceImpl.java:469)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:592)
      at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:309)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
      at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:67)
      at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:60)
      at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:60)
      at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:60)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
      at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:89)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
      at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)
      at $Proxy140.updateFileEntry(Unknown Source)
      at com.liferay.portlet.documentlibrary.service.DLFileEntryServiceUtil.updateFileEntry(DLFileEntryServiceUtil.java:239)
      at com.liferay.portlet.documentlibrary.webdav.DLWebDAVStorageImpl.putResource(DLWebDAVStorageImpl.java:675)
      at com.liferay.portal.webdav.methods.PutMethodImpl.process(PutMethodImpl.java:32)
      at com.liferay.portal.webdav.WebDAVServlet.service(WebDAVServlet.java:112)
      at com.liferay.portal.webdav.BaseWebDAVTestCase.service(BaseWebDAVTestCase.java:220)
      at com.liferay.portal.webdav.BaseWebDAVTestCase.servicePut(BaseWebDAVTestCase.java:319)
      at com.liferay.portal.webdav.WebDAVOSXTest.testMSOffice3Modify(WebDAVOSXTest.java:283)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:592)
      at junit.framework.TestCase.runTest(TestCase.java:168)
      at junit.framework.TestCase.runBare(TestCase.java:134)
      at junit.framework.TestResult$1.protect(TestResult.java:110)
      at junit.framework.TestResult.runProtected(TestResult.java:128)
      at junit.framework.TestResult.run(TestResult.java:113)
      at junit.framework.TestCase.run(TestCase.java:124)
      at junit.framework.TestSuite.runTest(TestSuite.java:232)
      at junit.framework.TestSuite.run(TestSuite.java:227)
      at junit.framework.TestSuite.runTest(TestSuite.java:232)
      at junit.framework.TestSuite.run(TestSuite.java:227)
      at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
      at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
      at junit.framework.TestResult.runProtected(TestResult.java:128)
      at junit.extensions.TestSetup.run(TestSetup.java:27)
      at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:420)
      at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:911)
      at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:768)
      18:10:10,417 INFO [WebDAVServlet:136] OSX: (testMSOffice3Modify:283) PUT /webdav/guest/document_library/WebDAVTest/._Test.docx 409
      18:10:10,557 INFO [WebDAVServlet:136] Setup: (tearDown:65) DELETE /webdav/guest/document_library/WebDAVTest/ 204
      Tests run: 27, Failures: 1, Errors: 0, Time elapsed: 32.25 sec
      Tests run: 27, Failures: 1, Errors: 0, Time elapsed: 32.25 sec