Liferay Calendar, Duplicate Events Upon Import

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.1.0 CE RC1
• Fix Version/s: --Sprint 11/12, 6.2.0 CE M2
• Component/s: Calendar, Collaboration
• Labels:
  • QA-R
• Environment: Liferay 6.0
• Fix Priority: 3
• Liferay Contributor's Agreement:
  Accept
• Similar Issues: Show 5 results ; ;

  LPS-13555	GRP Calendar - Importing Events allows for identification and purging of duplicates
  LPS-12077	Calendar - Import recurring events issue
  LPS-33056	Enterprise Calendar - Importing ics of calendar with past events will not display imported events correctly
  LPS-11695	Calendar Events do not Import correctly
  LPS-29509	Export Calendar Allday event

1. Import Calendar .ics file into Liferay.
2. Change .ics file through Outlook by adding another event.
3. Reimport the new .ics file into Liferay.
4. See duplicates of events that have already been imported previously.

[Juan Fernández]

Hi Jenny:
I moved this to product backlog so that this can be corrected in the next major version.
Thanks!

[Tomáš Polešovský]

This issue is being addressed as part of the 100 PaperCuts program. Please see http://liferay.com/community/100-papercuts

[Tomáš Polešovský]

Attaching patch for CalEventServiceImpl.java

[Tomáš Polešovský]

Patched logic:

• Events are now also updated (merged), not just created
• Events are identified by VEVENT:UID which is mapped into DB as UUID field
• Events with same UID (UUID) are merged, events with new UID are created as new

Jenny, please could you verify it and click Accept Contribution? Thank you.

[Peter Shin]

Thank you for your contribution.

Reviewed the patch and added some updates:

• added PortalUUIDUtil#generate utility method
• handled duplicate CalEvents for VEvents exported by Liferay portal
• simplified logic so its easier to read

[Mark Jin]

PASSED Manual Testing following steps in description.

Reproduced on:
Tomcat 6.0 + MySQL 5. Firefox 5.0. 6.1.x Revision 85650.

Fixed on:
Tomcat 6.0 + MySQL 5. Firefox 5.0. 6.1.x Revision 86440.

[Justin Choi]

I am reopening this ticket because when the user imports an .ics file that has been modified in Outlook 2007 by adding another event into a Liferay Calendar that already has an event, there are duplicate events marked Busy in the title field. See screenshot titled "86915 calendar duplicate even import.jpg"

Failed on:
Tomcat 6.0.32 + MySQL 5. 6.1.x Revision 86915

[Peter Shin]

Hi Justin,

Can you list out the steps to reproduce the issue you're seeing (similar to the steps listed in the description)?

When you're done, reassign the ticket to me and will take a look.

[Justin Choi]

Hi Peter,

I was able to reproduce the same error on the latest 6.2.x.

This is the environment that I used:
Tomcat 7.0 + MySQL 5. Trunk GIT ID: af03df00e06d0880584b370e4e2a731c90a7bd51.

Steps taken:
1. Add an event on MS Outlook.
2. Export as an ICS file.
3. Import that ICS file to Liferay Calendar.
4. In Outlook, add a second event.
5. Save and Export as an ICS with the same name.
6. Import the updated ICS to Liferay Calendar.
7. The duplicate event displays.

[Peter Shin]

Hey Justin,

Thanks for outlining the steps. Added a few intermediate steps.

1. Add an event on MS Outlook. 
2. Export ICS file.
   -  for detail select "Full Details"
3. Import that ICS file to Liferay Calendar.
4. In Outlook, import the original ICS file.
   - this is done to preserve the UID (otherwise duplicates are created)
5. In Outlook, add a second event.
6. Save and Export as an ICS with the same name.
   -  for detail select "Full Details"
7. Import the updated ICS to Liferay Calendar.

Test with the updated steps and see if it fixes the issue.

I'm thinking the test steps are incorrect, so this should be marked as Won't Fix. In this case though, just mark it as fixed, since the original ticket relates to adding a new feature.

[Justin Choi]

Per Peter's last comments and amended steps, I am closing this ticket as "fixed." I have verified that at the latest version of trunk, there are no duplicate entries after importing the modified ICS file. See the latest screenshot called 100044 Calendar duplicat entry.

Fixed on:
Tomcat 7.0 + MySQL 5. Trunk Revision: 100044.