Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Concurrent edit by two users may overwrite Wiki draft

Description

In WikiPageLocalServiceImpl.java, the updatePage() method checks for concurrent edits by testing the WikiPage version. PageVersionException is thrown if the currently saved version number is greater than the version being edited.

This logic will fail to detect concurrent edits if multiple drafts are saved since each draft retains the same version number.

Possible solutions would be to check the modified date instead of the version number, or add an additional revision field to the WikiPage table. Since version is stored as a double, it is not possible to store sub-revisions within the version number (e.g. 1.2.5).

To reproduce:
1. Go to a Wiki page and click "Edit"
2. Make some changes and click Save as Draft.
3. Leave the editor open in this window and start a new session in a different browser. Go to the same Wiki page and click "Edit".
4. The draft content saved in the first browser is loaded. Make some more edits and save as draft.
5. Going back to the first window which is still open in the editor, make some more changes and save.
6. The edits that were made in the second browser have now been lost.

Environment

Tomcat 6.0.29 + MySQL. Firefox 3.6.13. 6.0.x Revision: 77302. Tomcat 6.0.29 + MySQL. Firefox 3.6.13. 6.1.x Revision: 77302.

Activity

Show:

Cynthia Wilburn March 12, 2012 at 2:14 PM

Reopening to add 6.1.1 CE GA2. Close as Fixed.

Luyang Tan February 7, 2012 at 11:39 PM

PASSED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. 6.2.x GIT ID: f074da2b0ec4e7c2bbe653d5542536b49cc2c7c2.

I can save the content in the first browser successful. The edits that were made in the second browser have been lost.

Fixed on:
Tomcat 7.0 + MySQL 5. 6.1.x GIT ID: 6d6b8814da7c7295ed4cab8420e070793361f856.
Tomcat 7.0 + MySQL 5. 6.2.x GIT ID: 71ce8e940ae12bae24e2a5e14cf3f836bb291915.

When I click save in the first browser, I can see the error message:
"Another user has made changes since you started editing. Please copy your changes and try again."

Michael Saechang February 3, 2012 at 10:29 AM

Committed on:
6.1.x GIT ID: 953003f67ce05d816a51a162b178d5db00a4dd64.
6.2.x GIT ID: 61e910d08e5613765e49d0abb616aee04994755e.

Brian Chan February 3, 2012 at 9:16 AM

Michael Saechang January 30, 2012 at 11:48 AM

Updating ticket as per Hitoshi's comment. Thank you for verifying.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Branch Version/s

6.1.x

Backported to Branch

Committed

Fix Priority

3

Git Pull Request

Components

Fix versions

Affects versions

Priority

Zendesk Support

Created February 14, 2011 at 9:37 AM
Updated June 24, 2023 at 9:51 AM
Resolved March 12, 2012 at 2:35 PM