MVCPortlet callActionMethod won't handle last action in list unless the list ends with a comma

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.0.6 GA
• Fix Version/s: --Sprint 12/11, 6.1.0 CE RC1
• Component/s: Tools > Plugins SDK > Portlets
• Labels: None
• Liferay Contributor's Agreement:
  Accept
• Similar Issues: Show 5 results ; ;

  LPS-11974	MVCPortlet callActionMethod can not be execute correctly
  LPS-26900	Dynamic Data List: Data in a List's Spreadsheet View won't be actually saved
  LPS-4705	Better handling of an empty list of static portlets in the configuration
  LPS-4720	Add Action support for MVCPortlet
  LPS-19213	Actions button doesn't appear in Document Library list display style

com.liferay.util.bridges.mvc.ActionCommandCache.getActionCommandChain() parses the list of Actions. If the list doesn't end with a comma, the last Action in the list is ignored.

[Deb Troxel]

This issue is a backlog candidate for the 100 PaperCuts program. Please consider participating! See http://liferay.com/community/100-papercuts

[Deb Troxel]

See discussion at http://www.liferay.com/community/forums/-/message_boards/message/8188060

[marco weiland]

imho we can fix that problem by replacing getActionComandChain method with this code:

public List<ActionCommand> getActionCommandChain(
String actionCommandChain) {

List<ActionCommand> actionCommands = _actionCommandChainCache.get(
actionCommandChain);

if (actionCommands != null)

{ return actionCommands; }

else

{ actionCommands = new ArrayList<ActionCommand>(); }

for ( String commandString : actionCommandChain.split(CharPool.COMMA+"
s*")){

ActionCommand actionCommand = getActionCommand(commandString);

if (actionCommand != EMPTY)

{ actionCommands.add(actionCommand); }

else {
if (_log.isWarnEnabled())

{ _log.warn( "Unable to find ActionCommand " + actionCommandChain); }

}
}

_actionCommandChainCache.put(actionCommandChain, actionCommands);

return actionCommands;
}

[marco weiland]

patch

[marco weiland]

svn patch

[Cynthia Wilburn]

Hi Deb - Was the provided patch a solution to the issue report? Thanks for your help!

[Deb Troxel]

Hi Cynthia,
Yes, Marco's patch resolves the issue.