Oracle 10g throws "Invalid column name" exception when running 5.2.0 upgrade script

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.1.2
• Fix Version/s: 5.2.0
• Component/s: None
• Labels: None
• Liferay Contributor's Agreement:
  Accept
• Similar Issues: Show 5 results ; ;

  LPS-25971	Upgrade to 6.1 throws SQLException: Invalid column name in v6_0_12_to_6_1_0.UpgradeMessageBoards (Oracle from 6.0.12 to 6.1.10)
  LPS-12201	ORA-00911: invalid charactrer in Message Boards (Oracle 10g)
  LPS-25183	DB Upgrade - Oracle - Throws Exceptions in the console and server stops due to unexpected startup errors - 5.2.3, 6.0.6 to 6.1.x, 6.2.x
  LPS-404	Extra invalid column identifiers
  LPS-27043	Inconsistent Datatype Error using JNDI name on Weblogic 10.3.2 with Oracle 10g

This is called by ResultSet.get() lookups using a fully-qualified column name (for example, Permission_.permissionId). The ResultSet object provided by the Oracle 10g driver shortens this to just PERMISSIONID, so whenever we attempt to lookup Permission_.permissionId, the lookup fails with an "Invalid column name" exception.

[Minhchau Dang]

The current solution is to wrap the ResultSet with a custom ResultSetWrapper object which uses the following algorithm to lookup the value of the column.

1. First, we check to see if there is a column in the result set with the fully-qualified name.
2. That failing, we check to see if there is a column in the result set with a shortened name (everything after the period).
3. If even fails, we delegate the search to the vender-specific ResultSet try to figure it out with its own algorithms.

Since each lookup involves a linear search against the list of column names in the result set, we cache them to improve performance.

[Minhchau Dang]

Committed revision 21715.

[Raymond Auge]

Minhchau, this broken the build... ResultSet is missing about 50 methods. As a result we can't build trunk.

[Raymond Auge]

ResultSetWrapper is missing these methods:

The type ResultSetWrapper must implement the inherited abstract method ResultSet.getHoldability()
The type ResultSetWrapper must implement the inherited abstract method ResultSet.getNCharacterStream(int)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.getNCharacterStream(String)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.getNClob(int)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.getNClob(String)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.getNString(int)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.getNString(String)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.getRowId(int)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.getRowId(String)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.getSQLXML(int)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.getSQLXML(String)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.isClosed()
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateAsciiStream(int, InputStream, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateAsciiStream(int, InputStream)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateAsciiStream(String, InputStream, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateAsciiStream(String, InputStream)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateBinaryStream(int, InputStream, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateBinaryStream(int, InputStream)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateBinaryStream(String, InputStream, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateBinaryStream(String, InputStream)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateBlob(int, InputStream, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateBlob(int, InputStream)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateBlob(String, InputStream, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateBlob(String, InputStream)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateCharacterStream(int, Reader, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateCharacterStream(int, Reader)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateCharacterStream(String, Reader, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateCharacterStream(String, Reader)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateClob(int, Reader, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateClob(int, Reader)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateClob(String, Reader, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateClob(String, Reader)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNCharacterStream(int, Reader, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNCharacterStream(int, Reader)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNCharacterStream(String, Reader, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNCharacterStream(String, Reader)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNClob(int, NClob)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNClob(int, Reader, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNClob(int, Reader)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNClob(String, NClob)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNClob(String, Reader, long)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNClob(String, Reader)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNString(int, String)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateNString(String, String)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateRowId(int, RowId)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateRowId(String, RowId)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateSQLXML(int, SQLXML)
The type ResultSetWrapper must implement the inherited abstract method ResultSet.updateSQLXML(String, SQLXML)
The type ResultSetWrapper must implement the inherited abstract method Wrapper.isWrapperFor(Class<?>)
The type ResultSetWrapper must implement the inherited abstract method Wrapper.unwrap(Class<T>)

[Raymond Auge]

It might be a difference in our JDK versions, but this is still a problem.

I'm on Java(TM) SE Runtime Environment (build 1.6.0_07-b06).

[Thiago Leão Moreira]

I'm using the same JDK version as Ray and also getting the same problem.

[Minhchau Dang]

Ack, I'm running on Java 1.5. I'll update my Java and fix this.

java version "1.5.0_15"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_15-b04)
Java HotSpot(TM) Client VM (build 1.5.0_15-b04, mixed mode, sharing)

[Brian Chan]

I'm using JDK 5 and it works, so it's a 5 vs. 6 issue.

[Minhchau Dang]

Committed revision 21738.

[Brian Chan]

I'm fixing ths...

[Brian Chan]

Fixed and renamed to SmartResultSet

[Brian Chan]

I backported SmartResultSet since it's a new wrapper that is very useful and will most likely be needed for future fixes.