CLONE - Allow dynamic addition of Servlet Filters - Apache Wicket Portlets BROKEN

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 5.2.3
• Fix Version/s: None
• Component/s: API, API > JavaScript
• Labels: None
• Branch Version/s:
  5.2.x, 6.0.x
• Backported to Branch:
  Committed
• Technical Documentation Required:
  Needs Documentation
• Liferay Contributor's Agreement:
  Accept
• Similar Issues: Show 5 results ; ;

  LPS-14894	Allow dynamic addition of Servlet Filters
  LPS-910	create a wicket portlet using wicket 1.4
  LPS-9678	Create a sample Wicket portlet
  LPS-7989	Problem with wicket ajax handling if community as virtualhost
  LPS-32144	As a site administrator I can filter the visible set of users in the Directory portlet

Creating a Delegation filter that will handle all servlet filtering needs of portal. This allows dynamically adding new filters and filter mapping. Current filters and mappings are moved to liferay-filter-web.xml which is read by this filter. Basically this filter takes over the job of servlet container and allows to do optimizations in addition to adding new filters dynamically.

[Fuad Efendi]

As of Release 81403, Apache Wicket Portlets (v.1.4.x) functionality is broken, and the cause is introduced InvokerFilter and related staff. Note that Apache Wicket works fine in pre-71000 releases.

[Fuad Efendi]

Related: LPS-15143

I couldn't figure out where "path" goes; it seems Wicket Portlet never receives it:
HttpServletRequest request = (HttpServletRequest)servletRequest;
String uri = getURI(request);
request.setAttribute(WebKeys.INVOKER_FILTER_URI, uri);

"URI" doesn't include path.

[Fuad Efendi]

This is new style, liferay-web.xml should be used to define filters, AND Wicket Filter doesn't work this way - it uses hardcoded access to web.xml:

<filter>
<filter-name>test</filter-name>
<filter-class>com.liferay.portal.kernel.servlet.PortalClassLoaderFilter</filter-class>
<init-param>
<param-name>filter-class</param-name>
<param-value>org.apache.wicket.protocol.http.WicketFilter</param-value>
</init-param>
<init-param>
<param-name>detectPortletContext</param-name>
<param-value>true</param-value>
</init-param>
<init-param>
<param-name>applicationClassName</param-name>
<param-value>org.tokenizer.test.WicketApplication</param-value>
</init-param>
</filter>

[Fuad Efendi]

SO that fix to the problem would be implementing new WicketFilter... might be... any thoughts?

[Mika Koivisto]

Fuad can you provide a simple Wicket Portlet that I could use to debug this. I really don't know Wicket at all so having that would be very helpful.

If you manually move the WicketFilter definition to web.xml after deployment does it then work?

[Fuad Efendi]

Hi Mika,

I found the source of a problem: http://issues.liferay.com/browse/LPS-17363

I did probably 20-30 checkouts, Log(O). Revision 80862 works fine, and Revision 80866 does not work (right after LPS-17363 which changes PortletRequest/Response & Filter behavior).

Attached is simple application, with altered Wicket (so it can read settings from liferay-web.xml); "Echo Form" prints whatever user input is. You can test it as a regular application via http://localhost:8080/test-wicket-form-1.0/test
and also test as a portlet.

[Fuad Efendi]

Wicket "Echo" form (from samples); altered wicket.jar embedded (it understands liferay-web.xml)

[Fuad Efendi]

To fix that, checkout trunk, and revert 3 files to Rev 80862.

–
Fuad Efendi
http://www.tokenizer.ca

[Wesley Gong]

Hi Fuad,
LPS-18275 will fix the problems you are having on this ticket. If you update to revision 84235, you will have all the changes from this ticket.

Thanks,
Wes

[Fuad Efendi]

Hi Wes,

I tried to test simple Wicket Portlet ("echo" form submission) in revision 84698; it doesn't work.

Please deploy attached portlet; it will be "test" portlet in "Wicket" category. It is also available via http//localhost:8080/test-wicket-form-1.0/test

• Wicket uses Servlet filters to convert Portlet Request/Response into HTTP Request/Response.

Thanks,
Fuad

[Wesley Gong]

Hi Fuad,
This has now been fixed in revision 84772. Thanks again for bringing this to our attention!

-Wes

[Wesley Gong]

This ticket has been resolved in LPS-18275