PUBLIC - Liferay Portal Community Edition

Review markup and headers

Details

  • Branch Version/s:
    6.1.x
  • Backported to Branch:
    Committed
  • Similar Issues:
    Show 4 results 
  • Liferay Contributor's Agreement:
    Accept

Description

Estimated Time: 12 hours

The markup should be reviewed for the following situations:

  • When the portlet title is visible, that is the H1 of the section (html5 markup), so portlet headers should start from H2, this happens in blogs, wiki pages or message boards (should we create an aui:h1 aui:h2 aui:h3 for this?)
  • Blog titles don't have appropiate markup (in summary view)
  • Polls Display: options should be a list. Results table markup should be improved.
  • Top Links should be grouped as a list (message boards, doc library display... search for top_links.jsp)
  • Missing legend in fieldset (schedule in Web Content)
  • missing title in the tags selector input (with some instruccions about how to use the component)
  • Apply <strong> tag to selected tab in liferay-ui:tabs

Attachments

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Asier del Pozo added a comment -

Blog-Header-Hook
Solves the problem : When the portlet title is visible, that is the H1 of the section (html5 markup), so portlet headers should start from H2, this happens in blogs, wiki pages or message boards (should we create an aui:h1 aui:h2 aui:h3 for this?)

blog-Tags-Input-Label
Solves the problem : missing title in the tags selector input (with some instruccions about how to use the component)

calendar_DayView_header
The events are grouped as an ordered list (by start hour).

Calendar-Summary-Header-hook-6.1.0.1
It unifies the contents of both headers and changes the presentation of ordinal by a span

Calendar-Summary--hook-6.1.0.1.war
Current day is labelled correcty in the calendar table by a caption field.

DocLibraryDisplay-Top-Links-hook-6.1.0.1.war
Changed the top links of DocLibrary Display.

Polls-Display-hook-6.1.0.1.war
Solves the problem : Polls Display: options should be a list. Results table markup should be improved.
ratings-hook-6.1.0.1.war
Solves the problem of blogs ratings.

Selected-Tab-Font-Weight-hook-6.1.0.1.war
Solves the problem :Apply <strong> tag to selected tab in liferay-ui:tabs.

Top-Links-hook-6.1.0.1.war
Solves the problem : Top Links should be grouped as a list : Message boards

Show
Asier del Pozo added a comment - Blog-Header-Hook Solves the problem : When the portlet title is visible, that is the H1 of the section (html5 markup), so portlet headers should start from H2, this happens in blogs, wiki pages or message boards (should we create an aui:h1 aui:h2 aui:h3 for this?) blog-Tags-Input-Label Solves the problem : missing title in the tags selector input (with some instruccions about how to use the component) calendar_DayView_header The events are grouped as an ordered list (by start hour). Calendar-Summary-Header-hook-6.1.0.1 It unifies the contents of both headers and changes the presentation of ordinal by a span Calendar-Summary--hook-6.1.0.1.war Current day is labelled correcty in the calendar table by a caption field. DocLibraryDisplay-Top-Links-hook-6.1.0.1.war Changed the top links of DocLibrary Display. Polls-Display-hook-6.1.0.1.war Solves the problem : Polls Display: options should be a list. Results table markup should be improved. ratings-hook-6.1.0.1.war Solves the problem of blogs ratings. Selected-Tab-Font-Weight-hook-6.1.0.1.war Solves the problem :Apply <strong> tag to selected tab in liferay-ui:tabs. Top-Links-hook-6.1.0.1.war Solves the problem : Top Links should be grouped as a list : Message boards
Hide
Permalink
Vicki Tsang added a comment -

Dear Asier,

Thank you for your contribution. It appears that when the original contribution was made, the Liferay Contributors Agreement was not checked. I have returned this ticket to the reopened state. Please can you verify that the patches will still work with our current release and click on the Contribute Solution button. Once you have accepted the Liferay Contributor's Agreement, our engineering team can identify it for review. Submissions that do not have the Liferay Contributor's Agreement checked cannot be considered for inclusion in the product.

I apologize for any inconvenience this may have caused.

Thanks,

The Liferay Team

Show
Vicki Tsang added a comment - Dear Asier, Thank you for your contribution. It appears that when the original contribution was made, the Liferay Contributors Agreement was not checked. I have returned this ticket to the reopened state. Please can you verify that the patches will still work with our current release and click on the Contribute Solution button. Once you have accepted the Liferay Contributor's Agreement, our engineering team can identify it for review. Submissions that do not have the Liferay Contributor's Agreement checked cannot be considered for inclusion in the product. I apologize for any inconvenience this may have caused. Thanks, The Liferay Team
Hide
Permalink
Julio Camarero added a comment -

Voy a ir comentando algunas dudas que me van surgiendo al aplicar esto:

Ratings hook --> Sólo contiene una linea que dice "esto son los ratings" y un css de blogs sin cambios

Show
Julio Camarero added a comment - Voy a ir comentando algunas dudas que me van surgiendo al aplicar esto: Ratings hook --> Sólo contiene una linea que dice "esto son los ratings" y un css de blogs sin cambios
Hide
Permalink
Julio Camarero added a comment -

Polls Display hook --> El código ha cambiado tanto en trunk que no es nada fácil aplicarlo, podríais actualizarlo?

Show
Julio Camarero added a comment - Polls Display hook --> El código ha cambiado tanto en trunk que no es nada fácil aplicarlo, podríais actualizarlo?
Hide
Permalink
Julio Camarero added a comment -

Selected tab hook --> Creo que este cambio ya está presente en trunk, lo podríais verificar?

Show
Julio Camarero added a comment - Selected tab hook --> Creo que este cambio ya está presente en trunk, lo podríais verificar?
Hide
Permalink
Julio Camarero added a comment -

blogs-header-hook --> únicamente añade cambio de estilo?

Show
Julio Camarero added a comment - blogs-header-hook --> únicamente añade cambio de estilo?
Hide
Permalink
Michael Saechang added a comment -

Committed on:
6.1.x GIT ID: 19bd07f8fae16f46c4f49b46a05254c1223d0f60.
6.2.x GIT ID: 19bd07f8fae16f46c4f49b46a05254c1223d0f60.

Show
Michael Saechang added a comment - Committed on: 6.1.x GIT ID: 19bd07f8fae16f46c4f49b46a05254c1223d0f60. 6.2.x GIT ID: 19bd07f8fae16f46c4f49b46a05254c1223d0f60.
Hide
Permalink
Ginson Ren added a comment -

PASSED Manual Testing using the following steps:
1. Add wiki porlet.
2. Inspect element of the top right link.

Reproduced on:
Tomcat 7.0.25 + MySQL 5. 6.2.x GIT ID: e655d5a320e27777e78d18e7d8482d412cbe83f4.
The source contain a lot of div tags:
<span class="top-link">
<a id="_36_ocng" class="taglib-icon" href="http://localhost:8080/web/guest/home/-/wiki/Main/all_pages">
<img class="icon aui-icon-document" style="background-image: url('/html/themes/classic/images/aui/icon_sprite.png'); height: 16px; width: 16px;" alt="" src="/html/themes/classic/images/spacer.png">
<span class="taglib-text">All Pages</span>
</a>
</span>

Fixed on:
Tomcat 7.0.25 + MySQL 5. 6.1.x GIT ID: 68b99679c98d9eb177b10d681371d8fc291e7e66.
Tomcat 7.0.25 + MySQL 5. 6.2.x GIT ID: fcfb50d00f9c3b05bf819a0509ec7cd998da0440.
The souce are list of items:
<li class="top-link">
<span>
<a id="_36_umre" class="taglib-icon" href="http://localhost:8080/web/guest/home/-/wiki/Main/all_pages">
<img class="icon aui-icon-document" style="background-image: url('/html/themes/classic/images/aui/icon_sprite.png'); height: 16px; width: 16px;" alt="" src="/html/themes/classic/images/spacer.png">
<span class="taglib-text">All Pages</span>
</a>
</span>
</li>

Show
Ginson Ren added a comment - PASSED Manual Testing using the following steps: 1. Add wiki porlet. 2. Inspect element of the top right link. Reproduced on: Tomcat 7.0.25 + MySQL 5. 6.2.x GIT ID: e655d5a320e27777e78d18e7d8482d412cbe83f4. The source contain a lot of div tags: <span class="top-link"> <a id="_36_ocng" class="taglib-icon" href="http://localhost:8080/web/guest/home/-/wiki/Main/all_pages"> <img class="icon aui-icon-document" style="background-image: url('/html/themes/classic/images/aui/icon_sprite.png'); height: 16px; width: 16px;" alt="" src="/html/themes/classic/images/spacer.png"> <span class="taglib-text">All Pages</span> </a> </span> Fixed on: Tomcat 7.0.25 + MySQL 5. 6.1.x GIT ID: 68b99679c98d9eb177b10d681371d8fc291e7e66. Tomcat 7.0.25 + MySQL 5. 6.2.x GIT ID: fcfb50d00f9c3b05bf819a0509ec7cd998da0440. The souce are list of items: <li class="top-link"> <span> <a id="_36_umre" class="taglib-icon" href="http://localhost:8080/web/guest/home/-/wiki/Main/all_pages"> <img class="icon aui-icon-document" style="background-image: url('/html/themes/classic/images/aui/icon_sprite.png'); height: 16px; width: 16px;" alt="" src="/html/themes/classic/images/spacer.png"> <span class="taglib-text">All Pages</span> </a> </span> </li>
Hide
Permalink
Cynthia Wilburn added a comment -

Reopening to add 6.1.1 CE GA2. Close as Fixed.

Show
Cynthia Wilburn added a comment - Reopening to add 6.1.1 CE GA2. Close as Fixed.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.4#664-r167664) | Report a problem
Powered by a free Atlassian JIRA open source license for Liferay. Try JIRA - bug tracking software for your team.