Portlet with render-weight=0 produce a JS error: 'h is undefined'

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: No Longer Reproducible
• Affects Version/s: 6.0.6 GA
• Fix Version/s: 6.2.0 CE M4
• Component/s: UI, UI > JavaScript & CSS
• Labels:
  • community-verifier
• Similar Issues: Show 5 results ; ;

  LPS-26494	Portlets with render-weight=0 (loaded via Ajax) need to load service.js manually
  LPS-27758	Uncaught TypeError: Cannot read property 'preventNotification' of undefined
  LPS-29263	Control Panel > Categories > Error: vocabularies is undefined
  LPS-29262	Control Panel > Tags > Error: tags is undefined
  LPS-28866	Look and Feel panel is not opening in IE8

Portlets configured with render-weight=0 fail executing h.delegate.syncTargets(); in d.refresh() due to the fact that d.layoutHandler is undefined.

var d = {
    ...
    
    refresh: function (i) {
        var h = d.layoutHandler;
        i = a.one(i);
        if (i) {
            h.delegate.syncTargets();
            Liferay.Layout.updatePortletDropZones(i)
        }
    },
    
    ...
}

[Oliver Färber]

/html/js/liferay/layout.js

var Layout = {
    ...
    refresh: function(portlet) {
        var layoutHandler = Layout.layoutHandler;

        portlet = A.one(portlet);

        if (portlet) {
            layoutHandler.delegate.syncTargets();

            Liferay.Layout.updatePortletDropZones(portlet);
        }
    }
    ...
}

[Oliver Färber]

Quick Fix via Hook:

refresh: function(portlet) {
    var layoutHandler = Layout.layoutHandler;

    portlet = A.one(portlet);

    if (portlet) {
        
        if(layoutHandler) {
            layoutHandler.delegate.syncTargets();
        }

        Liferay.Layout.updatePortletDropZones(portlet);
    }
}

[Oliver Färber]

It seems like there are a lot more JS errors related to the render-weight=0 setting, e.g. in the selector-css3 module...

[Alberto Chaparro]

When you set render weight to 0, the service.js file is not automatically loaded and if you need those services (for example, components like tags or categories selector use those services) the portlet will throw javascript exceptions.

You can avoid this loading the javascript file through your liferay-portlet.xml file, for example for this case:
<footer-portal-javascript>/html/js/liferay/service.js</footer-portal-javascript>

[Oliver Färber]

This does not seem to work for us, service.js is already included... still getting "i/h is undefined" errors.

[Tejas Kanani]

Thank you for the report. As part of our community verifier program, I am going to verify it against Liferay 6.2 CE M4 version. If found fixed on current version then it will be treated as fixed and issue will be closed.

[Tejas Kanani]

Verified it by following below steps.

• Created simple plugins portlet using Liferay 6.2 CE M4 Plugins SDK (without specifying any render-weight value)
• deployed and verified, working fine.
• added <render-weight>0</render-weight> in liferay-portlet.xml
• deployed and verified, found working fine and not getting any js error.

So Its likely to be fixed in current Liferay 6.2 CE M4 version and I recommend it to be fixed.