Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

top_head.jsp references CDN Host when loading css.jsp

Description

If the cdn.host.http or cdn.host.https properties are defined in portal-ext.properties, the host is incorporated into the URL for loading css.jsp within top_head.jsp. Line 30 shows the following, which includes a call to getCDNHost():

<link href="<%= HtmlUtil.escape(PortalUtil.getStaticResourceURL(request, themeDisplay.getCDNHost() + themeDisplay.getPathContext() + "/html/portal/css.jsp")) %>" rel="stylesheet" type="text/css" />

This is not correct. There is no sense in putting a JSP file on the CDN, as it won't be processed. The logic should be updated to remove the call to getCDNHost() and just reference the file from the Liferay server.

I have seen older tickets reported that are related to this (see LPS-12383), but it looks like these issues are only being addressed on a case-by-case basis. Given that this looks like the fourth or fifth such issue, would it make sense to do a deeper scan on all logic related to CDN usage, so we are sure that JSPs and other dynamic files aren't expected to be on the CDN?

Environment

Mac or Windows deployment using Tomcat 6.0.29 and Java 1.6

Activity

Show:

EdG April 16, 2013 at 10:24 AM

Hello everyone! We are in the process of removing component "Theme" from LPS. Please make the necessary adjustments to affected your filters. Thanks!

Cynthia Wilburn February 24, 2012 at 3:25 PM

Removing 6.1.1 CE GA2 from fixed-in. We are selecting the GA2 candidates and will re-add this upon approval from product management.

Michael Saechang February 10, 2012 at 2:49 PM

Committed on:
6.1.x GIT ID: 03929a0fdd6266f882aa99db4d137efa25e9c996.
6.2.x GIT ID: 03929a0fdd6266f882aa99db4d137efa25e9c996.

MikaM February 3, 2012 at 9:47 AM

You'll see the final Fix Versions once the ticket is closed. The current 6.2.x just means that the code is currently submitted for review to master/trunk. I'm sure this will be applied to 6.1 EE if not also to 6.1 GA2.

Joe Moran February 3, 2012 at 6:22 AM

Mika, this fix sounds perfect! Thanks for making it.

I'm still learning your system, so I was wondering if you can clarify the "Fix Version" entries and their expected release dates. Will this fix be released as part of 6.1.1 GA2 in addition to 6.2.x, or is this truly only going out whenever 6.2 is released?

We have a project going on that needs to be able to use Liferay with our CDN, and this fix is the key piece. We need to be able to tell our project managers when it's expected for release so we can manage expectations on our own timeline.

Fixed

Details

Assignee

Reporter

Labels

Branch Version/s

6.1.x
6.0.x

Backported to Branch

Committed

Epic/Theme

Fix Priority

4

Git Pull Request

Components

Fix versions

Affects versions

Priority

Zendesk Support

Created December 13, 2011 at 1:54 PM
Updated June 24, 2023 at 3:45 PM
Resolved July 13, 2012 at 6:05 PM
Loading...