Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Minifier fails for Dynamic Data Lists in French locale (and possibly many more)

Description

Switching to French locale and trying to create a new Dynamic Data List and associated Data Definition results in a huge minifier failure and non-functional feature. Very similar to https://liferay.atlassian.net/browse/LPS-24289#icft=LPS-24289.

To reproduce this:

1. Switch to French locale
2. Control Panel -> Dynamic Data Lists (Listes de données dynamique) -> Add (Ajouter)
3. Sélectionner (to select a data definition)
4. Add (Ajouter) to add a new data definition
5. Observe giant scary stack trace in log file:

21:59:55,089 ERROR [MinifierUtil:108] 475: 63: missing } after property list 21:59:55,092 ERROR [MinifierUtil:108] 475: 75: unterminated string literal 21:59:55,092 ERROR [MinifierUtil:108] 477: 4: missing ) in parenthetical 21:59:55,093 ERROR [MinifierUtil:108] 477: 5: syntax error 21:59:55,094 ERROR [MinifierUtil:108] 479: 14: syntax error 21:59:55,094 ERROR [MinifierUtil:108] 480: 22: syntax error 21:59:55,095 ERROR [MinifierUtil:108] 504: 4: missing ) after argument list 21:59:55,096 ERROR [MinifierUtil:108] 506: 3: syntax error 21:59:55,097 ERROR [MinifierUtil:108] 665: 1: syntax error 21:59:55,097 ERROR [MinifierUtil:108] 743: 9: syntax error 21:59:55,098 ERROR [MinifierUtil:108] 1: 0: Compilation produced 10 syntax errors. 21:59:55,114 ERROR [MinifierUtil:74] JavaScript Minifier failed for ...

Environment

French locale.

Activity

Show:

Luyang Tan January 29, 2012 at 7:20 PM

PASSED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. 6.1.x GIT ID: b21795a382bb7dea90bc58a147d6ed0bd32294de.

I can see the error the same as description.

Fixed on:
Tomcat 7.0 + MySQL 5. 6.1.x GIT ID: 085024b8f150d3b493ab5423794c7c1170b1cae3.
Tomcat 7.0 + MySQL 5. 6.2.x GIT ID: c5af4aa6349c4805f51c003bf56f3fdad826bcdf.

There's no error in the console.

Michael Saechang January 24, 2012 at 5:22 PM

Committed on:
6.1.x GIT ID: 20102f1776954d270563139cac1cba2a5d6370bd.
6.2.x GIT ID: 78fea908b7b97e4a346efc0bea17ab6ab5d2d5a0.

Raymond Augé January 20, 2012 at 2:37 PM

There are a couple of places that are not unicode encoding strings embedded in javascript objects.

portal-web/docroot/html/portlet/dynamic_data_mapping/form_builder.jspf, Line 159
portal-web/docroot/html/portlet/dynamic_data_mapping/custom_fields.jspf, Line 25, 197, 219

The result is complete failure of form builder when in a locale which uses chars outside the basic latin set.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Branch Version/s

6.1.x

Backported to Branch

Committed

Fix Priority

4

Git Pull Request

Components

Fix versions

Affects versions

Priority

Zendesk Support

Created January 20, 2012 at 2:15 PM
Updated June 24, 2023 at 3:50 PM
Resolved March 12, 2012 at 2:28 PM