unable to upload plugin

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: No Longer Reproducible
• Affects Version/s: 6.1.0 CE GA1
• Fix Version/s: --Sprint 11/12, 6.2.0 CE M2
• Component/s: Administration, Administration > Server > Plugin Installer
• Labels: None
• Environment: windows 7 x64 with jdk 1.7u2 and glassfish 3.1.2 b22
• Technical Documentation Required:
  Needs Documentation
• Similar Issues: Show 5 results ; ;

  LPS-25899	Unable to Upload Documents
  LPS-24679	Jonas - Unable to hot deploy plugins
  LPS-22950	Jonas - Unable to deploy the CAS Web plugin
  LPS-20062	WSRP - Unable to build the plugin portlet
  LPS-16100	Unable to upload a document to the document library

upon using the plugin upload facility to upload a portlet war file, user is presented with the attached error display.

no visible content in the log files regarding the cause of the error.

[peter belbin]

James (JHF) was able to reproduce the issue with his Glassfish 3.1.1 environment, but indicated that he saw some log file content, but, I do not believe it was very indicative of the cause of the error.

note: Copying the same .war file to the liferay deploy directory results in the portlet being deployed successfully.

[peter belbin]

looking into this further, in InstallPluginAction.java:269 which (as of 6.1GA1) has:

fileName = GetterUtil.getString(uploadPortletRequest.getFileName(
"file"));

even though the file name was given on the web page, the value is retrieved as being an empty string.

so, now the question is: why is 'file' not being populated??

[peter belbin]

digging a little bit further, and I'm seeing in UploadServletRequestImpl.UploadServletRequestImpl(HttpServletRequest) that after having had the request parsed by the ServletFileUpload (from apache commons) that it has not seen any files as being there to document as being part of the request.

this is the piece of code (around line 92 of the 6.1GA1 version of the source) that actually adds / populates the _params collection with the LiferayFileItems collection.

I'm wondering if the issue is not on the server side of this issue, but on the side that pushes the request to the servlet. ie: the browser based code is not constructing the request properly?

[Sharry Shi]

Hi Peter,

Thanks for the report. I tried to reproduce this issue on Liferay Portal 6.1.0 GA1 as well as our trunk head but could not. Here are the steps I tried:

1. Control Panel -> Plugins Installation ->Install More Portlets.
2. Upload a war file in Plugin Installer.

I got the successful upload information.

Please ensure you have a fresh environment with no other issues that may interfere with the bug. If you still experience this issue, please let me know how to reproduce the issue and we can re-visit it. If I cannot reproduce this issue, it cannot be fixed. Thanks!

[peter belbin]

For more information on how to reproduce it, Please talk to James Falkner, as he was able to reproduce the issue on a VM environment he had for other reasons.

and: what app/web server environment did you use? I am using Glassfish 3.1.2. I believe James might be using Glassfish 3.1.1.

[Sharry Shi]

Hi,Peter
I have my another workmate test this, she also was unable to reproduce it using Glassfish 3.1.1.

[peter belbin]

did you actually talk with James? even though your workmate may have demonstrated it working, James was able to demonstrate it not working.

also: I am using glassfish, but, not using one of your bundles. I manually followed the instructions on adding Liferay to an existing instance. I wonder if there are steps that are missing from the instructions that could be contributing to this issue?

note: since the patches from your organization have already been incorporated into the glassfish code, with glassfish 3.1.2, there is no need to do the manual updates of the glassfish jars. however, I do notice that in glassfish/modules, there is a commons-codec jar that is present in the pre-built package which is not in the normal glassfish download - so I am a bit suspicious that there may be some instructions missing on what is needed to properly add liferay to glassfish.

[Eric Tiongson]

I am encountering the same error that was reported. Additionally, I cannot also upload files using Document and Media.

Platform: Mac OS X Lion (latest update)
App Server: Glassfish v3.1.2 (opensource, full profile version)

Steps to reproduce (using Documents and Media):
1. downloaded and installed this - http://download.java.net/glassfish/3.1.2/release/glassfish-3.1.2-unix-ml.sh
2. copied the 3 jars in liferay dependencies (hsql.jar, portlet.jar, portal-service.jar) into <glassfish-dir>/glassfish/lib
3. adjusted a few JVM parameters (nothing major, just -Xmx and permSize)
4. restarted the server
5. using glassfish's admin console - deployed liferay-portal-6.1.0-ce-ga1-20120106155615760.war), changed context root to "/"
6. after deployment, I used the default values from Liferay's Basic Configuration screen (hsql, [e-mail], etc)
7. logged in, went into Control Panel -> Documents and Media
8. Tried to upload a document (Basic Document) <- Error! (Documents and Media is temporarily unavailable)

I only encounter the plugin and documents and media error when using Glassfish 3.1.2, with Glassfish 3.1.1 it works fine.

[James Falkner]

I have successfully reproduced this using GlassFish 3.1.2. After attaching to a debugger, it appears that the content stream has already been read, parsed, and closed by the time Liferay code gets to the point of parsing the multipart form data.

This is a result of the GlassFish Bugfix:
http://java.net/jira/browse/GLASSFISH-16740

And has been noticed by others, such as Magnolia CMS:
http://java.net/jira/browse/GLASSFISH-18444

I believe that the right fix is for GlassFish to respect annotations for servlets prepared to use the getParts()/getPart() API (which Liferay is not).

As a workaround it is possible for Liferay to try to use getPart()/getParts() first, and if unsucessful, revert to the existing method of parsing multipart form data.

IN any case this totally breaks Liferay's ability to upload files (e.g. to the Document Library, or uploading plugins to deploy, anything that uses the UploadServlet).

[James Falkner]

Confirmed that this has been fixed in GlassFish, presumably to show up in GlassFish 3.1.3, and the next nightly build.

There is also a fixed binary (web-core.jar) attached to the associated GlassFish bug that one can use, if they wish to use Liferay with GlassFish 3.1.2.

Assigning this to me for any future follow-up issues.

[Michael Saechang]

This issue looks related to LPS-25647.

[Edward Gonzales]

Hello everyone! We are in the process of removing component "Portlet" from LPS. Please replace this issue's component, "Portlet", with a new component. There are over 200+ components, in the newly organized component list. Also, make the necessary adjustments to affected filters. Thanks!