Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

StringUtil.shorten method doesn't work properly

Description

Try the following test case:
StringUtil.shorten("Inspire Designer Related - Inspire Content Manager Web Installation Guide 8.0", 75, "...");
It shortens the title to:
Inspire Designer Related - Inspire Content Manager Web Installation Guide...
Which is actually 76 characters long.
It is caused by this code:
http://svn.liferay.com/repos/public/portal/trunk/portal-service/src/com/liferay/portal/kernel/util/StringUtil.java

there should be for (int j = (length - suffix.length()); j >= 0; j--) {
instead of for (int j = length; j >= 0; j--) {

Activity

Show:

Michael Saechang June 28, 2012 at 3:09 PM

Committed on:
Portal 6.1.x CE GIT ID: 3338bfafdbc455d7ea1fd4ece587c7dc49ee686a.
Portal 6.2.x GIT ID: 014990353b388ede8576760eb598a692ec1587ac.

Jan Tošovský May 24, 2012 at 3:16 AM

It is used here for shortening category names:
http://svn.liferay.com/repos/public/portal/trunk/portal-impl/src/com/liferay/portlet/wiki/importers/mediawiki/MediaWikiImporter.java
The maximum category name length is exactly 75 characters.

Shinn Lok May 22, 2012 at 11:28 AM

Gotcha. Thanks for the response. I'll look more into it.

Jan Tošovský May 22, 2012 at 11:24 AM

Thanks for analyzing this. But I'd like to emphasise the real problem. This method is used before storing some string values into database. And that number is the maximum field size. In my case I am getting an exception and my value is not stored. It is used e.g. for shortening Wiki Page Titles.
Either fix this method or do not use it for shortening as the final length can be bigger than the database field.

Shinn Lok May 22, 2012 at 10:49 AM

Hey Jan,

The code is actually working as intended. Shorten is not supposed to count the suffix. What's happening in your case is that "8.0" brings the character count to 77 so it looks at the count without the whitespace + "8.0" (73 chars) and appends the suffix. Please look at these test cases which all pass.

Thanks!

Fixed

Details

Assignee

Reporter

Branch Version/s

6.1.x

Backported to Branch

Committed

Git Pull Request

Components

Fix versions

Affects versions

Priority

Zendesk Support

Created May 22, 2012 at 5:05 AM
Updated June 24, 2023 at 3:56 PM
Resolved June 7, 2012 at 5:55 PM
Loading...