Look-and-feel show borders should be a three state switch

Description

None

Activity

Show:

Pani Gui July 15, 2012 at 7:54 PM

PASSED Manual Testing using the following steps:

1. Add a portlet to a page.
2. Go to Look and Feel of the portlet.

Reproduced on:
Tomcat 7.0 + MySQL 5. 6.1.10 EE GA1.

Show Borders is as boolean mode.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 960a1f35e66bf04b587b4005989d04bba78ceada.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: c30f2892ee80137c93de9f524c09a10cb01383b5.

Show Borders is as select mode.

Michael Saechang July 11, 2012 at 4:16 PM

Committed on:
Portal 6.1.x CE GIT ID: 34f170edda53c1a75c3456996e608e6ce1482e38.
Portal 6.2.x GIT ID: 748de88c6a469f8548a97e47c296b492d7309b3a.

Zsolt Balogh July 2, 2012 at 6:49 AM

Hi Nate,

Sorry, I forgot to assign it to myself, I was already working on it on Sunday.

I have sent a pull req to Zsolt Berentey, please check it: https://github.com/zberentey/liferay-portal/pull/104

Thanks,
Zsolt

Zsolt Balogh July 2, 2012 at 6:41 AM

The problem is that we can switch on/off the defaults in the theme, but we must save the value when we change the look-and-feel. There's no way we can say to got with the default. This can cause serious problems.

Zsolt

Fixed

Details

Assignee

Reporter

Labels

Branch Version/s

6.1.x

Backported to Branch

Committed

Git Pull Request

Components

Priority

Zendesk Support

Created July 1, 2012 at 5:40 AM
Updated June 24, 2023 at 4:01 PM
Resolved July 2, 2012 at 2:12 PM
Loading...