Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Compiled .class file timestamps do not match .jsp timestamps, causing JSP precompilation to add no benefit in Tomcat 7

Description

Between Tomcat 6 and Tomcat 7, JSP compilation was updated to allow older JSP files to replace newer JSP files and trigger a recompilation. To do this, the timestamp checking was changed from a lenient check where as long as the .class file is newer than the .jsp file it's treated as up-to-date to a strict check where the .java and .class files will be given the same modified timestamp as the .jsp file.

As a result of this change, build-time JSP precompilation is adding no performance benefit because the .class files currently have a last modified timestamp of the time when they were generated. This means that Tomcat's modified timestamp check fails and Tomcat will try to regenerate the .java and .class files.

To fix this, we'll need to ensure that the timestamp of .class files are the same as the .java and .jsp files when we precompile for Tomcat 7 and above.

Activity

Show:

Mark Jin July 25, 2012 at 11:47 PM
Edited

PASSED Manual Testing using the following steps:

1. Add Documents and Media portlet.
2. Click Sort by drop menu.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.10 EE GA1.

Able to see Read Count button.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.20 EEGIT ID: f1f6bb02ad2c18e7b7e0b9908b2a8c2c7e7a4ac4.
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 7d6341f2d8702a8d152281f85f1f61911c75523f.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: fe67228df017e4f6d09873a025d9706bc1d9d8ef.

Unable to see Read Count button.

Michael Saechang July 18, 2012 at 4:27 PM

Committed on:
Portal 6.1.x CE GIT ID: 17133efd0bc7657e7cf31e70091c91a337c0d42a.
Portal 6.2.x GIT ID: 205737ba342e4ab1f27e54417cdf7e386a9b9b04.

Zsolt Balogh July 17, 2012 at 10:45 PM

Thanks. I've reported

Zsolt Balogh July 17, 2012 at 2:27 AM

Our documentation only mentiones the Read Count, here:
http://www.liferay.com/documentation/liferay-portal/6.1/user-guide/-/ai/lp-6-1-ugen04-getting-started-with-the-documents-and-media-portlet-0
Read Count: lets you sort documents by the number of times they were viewed.

I do believe that the Downloads is the right expression for this.

Zsolt Balogh July 17, 2012 at 2:16 AM

We can sort by Downloads and Read Count. The Downloads button is working and tracked in various places (e.g. when we switch off the read counters) while the readCount button seem to do nothing.

Fixed

Details

Assignee

Reporter

Labels

Branch Version/s

6.1.x

Backported to Branch

None

Git Pull Request

Components

Fix versions

Affects versions

Priority

Zendesk Support

Created November 10, 2011 at 1:04 PM
Updated June 24, 2023 at 3:34 PM
Resolved November 10, 2011 at 1:42 PM
Loading...
Loading...