Hook values for string arrays are overwritten instead of combined

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.1.2, 5.2.3
• Fix Version/s: None
• Component/s: None
• Labels: None
• Branch Version/s:
  5.1.x, 5.2.x
• Backported to Branch:
  Committed
• Similar Issues: Show 5 results ; ;

  LPS-22157	Allow mergeable properties to be overriden by hooks
  LPS-10628	Allow finder column to select an array of a certain column
  LPS-15598	JSON service expects String of arrays as a comma separated String
  LPS-31125	Accept JSON syntax as values for arrays and for objects
  LPS-31278	JSON Web Service Action value to string utility should serialize complex objects as well

"layout.static.portlets.all" is an example of a string array (ie comma delimited list of entries) that is customizable from a Hook.

But hooks should play safely with each other by adding onto the string array instead of overwriting each other.

Suppose you have test1-hook that has values "hello,world"

Suppose you have test2-hook that has values "alpha,beta"

Suppose the portal has a default value of "1_WAR_chatportlet"

The final value used in PropsValues.LAYOUT_STATIC_PORTLETS_ALL should resolve to:

1_WAR_chatportlet,hello,world,alpha,beta

Before the fix, it would either be:

"hello,world" or "alpha,beta" with no guarantee.

The order is still not guaranteed, but the values are now guaranteed to be merged.