Encode wiki links so that special characters can be used in JSPWiki content

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.0.1 RC
• Fix Version/s: 6.0.4 GA, 6.0.12 EE, 6.1.0 CE RC1
• Component/s: Collaboration > Wiki
• Labels:
  • QA-R
• Environment: All
• Branch Version/s:
  6.0.x
• Similar Issues: Show 5 results ; ;

  LPS-12088	Wiki creole links are not URL encoded
  LPS-28257	Interwiki-Links are not working using JSPWiki-Engine
  LPS-24954	Wiki attachments should be easily linked to (like in JSPWiki)
  LPS-12876	Links in Wiki pages in the guest community with special characters don't work and the user is redirected to the main page.
  LPS-29178	I can't insert special character in Wiki and Blogs portlet

Currently there are many characters that are not valid for use in the Wiki title. A big reason is due to the way JSP Wiki handles wiki links in its content. By encoding wiki links before JSP Wiki is given the content, we can provide the ability to use more characters in the wiki title.

Note: Tomcat needs a property to be set before an encoded forward slash is allowed to be used in the URL. If this is a character that is going to be used, set this property:

-Dorg.apache.tomcat.util.buf.UDecoder.ALLOW_ENCODED_SLASH=true

[Brian Chan]

Hey Doug,

I made changes in 54197 in case you decide to backport this. Thx.

[Douglas Wong]

Unless I'm told otherwise, we're not planning to backport this because it's considered an improvement.

[Raymond Auge]

You need to add the title regex validation change to the verifiers since it leaves data in the DB that no longer validates.

[Douglas Wong]

Hey John,

I did not make % a valid character, so that's why you may have trouble with that. Here's a list of characters that should be valid ' @ ^ ! ` ? / *

[Brian Chan]

I just rolled this back because it causes the syntax [[http://liferay.com | Liferay.com]] to no longer work

That happens because http:// gets cahnged to http:SLASLA which is the Creole interpreter doesn't understand.

[Douglas Wong]

This ticket is the cause of LPS-10202 and LPS-11598. Recommitting with these issues fixed.

[Robert Srisamang]

Tested in the following environments:

Tomcat 6.0.26 + MySQL 5. Firefox 3.6.16. Trunk Revision 54175.
Tomcat 6.0.29 + MySQL 5. Firefox 3.6.16. Trunk Revision 78782.

After testing both the older and newer revisions, wiki titles now except more special characters (' @ ^ ! ` ? / * &). Links in wiki content also work properly. Passed Manual Testing.