Uploaded image for project: 'PUBLIC - Liferay Alloy UI'
  1. PUBLIC - Liferay Alloy UI
  2. AUI-619

The hideClass on Component should be added during _uiSetVisible

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.2
    • Fix Version/s: 1.5.1, 1.6.0
    • Component/s: Component
    • Labels:
      None

      Description

      Currently we add the "hideClass" attribute in the base component class during the after change event. The down side to this is that the cssClass will only be added if a user calls .set('visible', false) (or .hide()) after construction, but if visible is passed as part of the constructor then it's not added.
      We should handle this logic inside of _uiSetVisible so that it's done during the sync phase as well as having the attribute bound.

        Attachments

          Activity

            People

            • Assignee:
              nathan.cavanaugh Nate Cavanaugh
              Reporter:
              nathan.cavanaugh Nate Cavanaugh
              Participants of an Issue:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                5 years, 35 weeks, 1 day ago