Uploaded image for project: 'PUBLIC - Liferay Commerce'
  1. PUBLIC - Liferay Commerce
  2. COMMERCE-3298

Currency minimum and maximum decimal place settings can be set so the minimum exceeds the maximum

    Details

      Description

      The Max/Min Decimal Places don't seem to care if the Min value exceeds the Max.

      Steps to Reproduce

      1. Go to Control Panel → Commerce → Settings → Currencies
      2. Create a currency
      3. Fill out the required fields
      4. Set a Min Decimal Places value which is greater than the Max Decimal Places value, .e.g
        1. Min: 10
        2. Max: 2

      Expected Behavior

      We throw a validation errors, because this would be impossible, letting the user know that the max must be equal to or greater than the min

      Actual Behavior

      Can save the currency

      Reproduced On

      7.2

      Tomcat 9.0.33 + HSQL 2.3.3
      DXP 7.2 git hash cf49d78b37a0575edbf96a54bf53199ac6fae0ca
      Commerce git hash fd1da8617e20241bb86e8662ff04f7a64edf0faf

      7.1

      Tomcat 9.0.33 + HSQL 2.3.3
      DXP 7.1 and Commerce git hash fd1da8617e20241bb86e8662ff04f7a64edf0faf

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              kristin.onias Kristin Onias
              Reporter:
              corbin.murakami Corbin Murakami
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Packages

                  Version Package
                  2.1.1