Uploaded image for project: 'PUBLIC - Liferay Commerce'
  1. PUBLIC - Liferay Commerce
  2. COMMERCE-3660

Do not allow the Multiple Selection option field type for SKU contributor options

    Details

      Description

      Background

      In COMMERCE-2895, it was decided that not all option field types should be allowed when an option was set as a SKU contributor.

      1. Update com.liferay.commerce.product.configuration.CPOptionConfiguration to provide list of allowed SKU contributor option types: "select|radio|checkbox_multiple"

      https://issues.liferay.com/browse/COMMERCE-2895?focusedCommentId=2089662&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-2089662

      This was mostly correct. Multiple Selection (checkbox_multiple) was erroneously permitted to be allowed as a SKU contributor.

      Definition of Done

      1. If an option is set to be a SKU contributor, it is not allowed to have the field type Multiple Selection (checkbox_multiple)
      2. If a user tries to set an option's field type to Multiple Selection and set SKU Contributor to TRUE, we reject saving and throw an error message in the UI.

      Notes

      There is configuration that I added:
      com.liferay.commerce.product.configuration.CPOptionConfiguration#skuContributorDDMFormFieldTypesAllowed
      it says that multi-select is allowed as SKU contributor option type. BUT it is wrong. I remember talking to you and you told me only select-from-list and single-select are allowed for SKU contributors
      We should:
      1) narrow configuration to select-from-list, single-select
      2) make sure that UI allows user to pick only proper values if SKU Contributor SWITCH = true

      If it is adjusted properly, then COMMERCE-1352 is BUG that is not a BUG but the case that is reproducible not-respecting the constraints and requirements

      Igor Beslic, https://issues.liferay.com/browse/COMMERCE-1352?focusedCommentId=2135945&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-2135945

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pietro.bocale Pietro Bocale
              Reporter:
              corbin.murakami Corbin Murakami
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Packages

                  Version Package
                  2.1.2