-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.1
-
Fix Version/s: 2.1.2
-
Component/s: Digital Merchandise Management → Options
-
Labels:
-
Epic Link:
Background
In COMMERCE-2895, it was decided that not all option field types should be allowed when an option was set as a SKU contributor.
1. Update com.liferay.commerce.product.configuration.CPOptionConfiguration to provide list of allowed SKU contributor option types: "select|radio|checkbox_multiple"
This was mostly correct. Multiple Selection (checkbox_multiple) was erroneously permitted to be allowed as a SKU contributor.
Definition of Done
- If an option is set to be a SKU contributor, it is not allowed to have the field type Multiple Selection (checkbox_multiple)
- If a user tries to set an option's field type to Multiple Selection and set SKU Contributor to TRUE, we reject saving and throw an error message in the UI.
Notes
There is configuration that I added:
com.liferay.commerce.product.configuration.CPOptionConfiguration#skuContributorDDMFormFieldTypesAllowed
it says that multi-select is allowed as SKU contributor option type. BUT it is wrong. I remember talking to you and you told me only select-from-list and single-select are allowed for SKU contributors
We should:
1) narrow configuration to select-from-list, single-select
2) make sure that UI allows user to pick only proper values if SKU Contributor SWITCH = trueIf it is adjusted properly, then
COMMERCE-1352is BUG that is not a BUG but the case that is reproducible not-respecting the constraints and requirements
Igor Beslic, https://issues.liferay.com/browse/COMMERCE-1352?focusedCommentId=2135945&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-2135945
- fixes
-
COMMERCE-2895 Can't generate SKUs if Option Field Type is a boolean
-
- Closed
-
-
COMMERCE-1352 Price not totaling properly for multi-select products
-
- Closed
-
- is related to
-
COMMERCE-2904 Improve the Product Options UI
-
- Closed
-
- relates
-
COMMERCE-3489 Change the ordering of the fields when editing an option on a product
-
- Closed
-