Uploaded image for project: 'PUBLIC - Liferay Commerce'
  1. PUBLIC - Liferay Commerce
  2. COMMERCE-3747

CommerceOptionValueHelper must have integration test

    Details

      Description

      CommerceOptionValueHelperImpl requires integration test for all public methods:

      public List<CommerceOptionValue> getCPDefinitionCommerceOptionValues(
      			long cpDefinitionId, String json)
      		throws PortalException;
      
      	public CommerceOptionValue toCommerceOptionValue(String json)
      		throws PortalException;
      
      	public List<CommerceOptionValue> toCommerceOptionValues(String json)
      		throws JSONException;
      

      test 0L and null parameters
      test NoSuchCPDefintion cpDefinition
      test empty JSON strings
      test invalid JSON strings for JSONException
      test valid cases

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marco.leo Marco Leo
              Reporter:
              igor.beslic Igor Beslic
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Packages

                  Version Package
                  2.1.1