We should not allow price lists to be their own parent price list

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.3
• Fix Version/s: 7.3, Master
• Component/s: Digital Merchandise Management → Price Lists, Digital Merchandise Management → Promotions
• Labels: None
• Severity of Issue: Major
• Git Pull Request: https://github.com/liferay-commerce/liferay-portal/pull/249
• Sprint: FlexSprint15

Assumptions

1. At least one price list in at lease one catalog

Steps to Reproduce

1. Create a price list and publish (e.g. Price List A)
2. Edit the price list (Price List A)
3. Assert that you can set the parent price list to the price list itself (Price List A)

Expected Result

Users are not allowed to set the price list as its own parent. In the list of available price lists to set as a parent, the current price list does not show up

Actual Result

Users are allowed to set the price list as their own parent.

Notes

• This is true of Price Lists and Sale Price lists. The same logic should apply for both.

Reproduced On

7.3

Tomcat 9.0.37 + HSQL 2.3.3
DXP 7.3 + Commerce liferay-commerce/liferay-portal:master git hash ab15fb32bd58e4f218c8270be54ba8a835e253b7