Uploaded image for project: 'PUBLIC - Liferay Commerce'
  1. PUBLIC - Liferay Commerce
  2. COMMERCE-4937

Unable to purchase not shippable subscriptions

    Details

      Description

      Liferay DXP 7.3 GA1 + Commerce 3.0 (Internal build pre-release)

      When purchasing a product with subscription enabled, but with "Shippable" disabled, the checkout fails at the payment step

      Steps to reproduce:

      1. Activate PayPal in the shop channel (with a valid sandbox configuration)
      2. Create a product (simple or virtual). Use case was using virtual products (software licenses) , but it fails for both product types.
      3. Enable Subscriptions on that product
      4. Set SKU or Product as "Not Shippable"
      5. Add product to the cart
      6. Proceed to checkout

      Expected result:

      Payment goes fine and checkout finalizes correclty

      Current result:
      Payment fails and order is not finalized.

      There is an ERRORin the log:

      2020-10-06 16:15:11.712 ERROR [http-nio-8051-exec-1][CommercePaymentServlet:158] java.lang.NullPointerException
      java.lang.NullPointerException
              at com.liferay.commerce.payment.method.paypal.internal.PayPalCommercePaymentMethod._getShippingAddress(PayPalCommercePaymentMethod.java:1213)
              at com.liferay.commerce.payment.method.paypal.internal.PayPalCommercePaymentMethod._getAgreement(PayPalCommercePaymentMethod.java:850)
              at com.liferay.commerce.payment.method.paypal.internal.PayPalCommercePaymentMethod.processRecurringPayment(PayPalCommercePaymentMethod.java:638)
              at com.liferay.commerce.payment.internal.engine.CommerceSubscriptionEngineImpl.processRecurringPayment(CommerceSubscriptionEngineImpl.java:303)
              at com.liferay.commerce.payment.internal.servlet.CommercePaymentServlet._startPayment(CommercePaymentServlet.java:199)
      
      

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pietro.bocale Pietro Bocale
              Reporter:
              daniel.defrancisco Daniel De Francisco
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Packages

                  Version Package
                  7.4 CE GA1
                  7.3.X