Uploaded image for project: 'PUBLIC - Liferay Commerce'
  1. PUBLIC - Liferay Commerce
  2. COMMERCE-6061

Review manual lint suppressions added to Commerce files in LPS-128988

    Details

    • Type: Task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Business Value (single choice):
      1

      Description

      We turned updated some lints in the latest version of @liferay/eslint-config, which is headed to liferay-portal now via:

      https://github.com/liferay-frontend/liferay-portal/pull/890

      As part of this, we had to add some lint suppressions, mostly in Commerce modules, as seen in this commit:

      https://github.com/liferay-frontend/liferay-portal/pull/890/commits/5c2e4946b09b79fc9f2e140b476765747e9b7b88

      Because LPS-128988 is an FP5, we went with suppressions instead of refactoring the code in order to avoid the lints, but I am creating this ticket for you to review the suppressions in your code that you can see in that commit and see if there is a way to do the "proper" fix for each.

      Specifically, there are a few instances of "eval" and a few of string-refs. I didn't look to see whether those string-refs are in Metal components (which only have string refs), so the fix for those is either to change them to use function refs, or change them to use React.

      Assigning to you Fabio Mastrorilli as my main guy "on the inside" of Commerce. Please feel free to re-assign or schedule as you see fit! Let me know if you have any questions.

        Attachments

          Activity

            People

            Assignee:
            fabio.mastrorilli Fabio Mastrorilli
            Reporter:
            greg.hurrell Greg Hurrell (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Packages

                Version Package