Uploaded image for project: 'PUBLIC - Liferay Faces'
  1. PUBLIC - Liferay Faces
  2. FACES-1755

Redundant condition in BridgeRequestScopeImpl.saveState

Details

    Description

      This appears twice in a row:

      if ((beganInPhase == Bridge.PortletPhase.ACTION_PHASE) || (beganInPhase == Bridge.PortletPhase.EVENT_PHASE) ||
      		(beganInPhase == Bridge.PortletPhase.RESOURCE_PHASE)) {
      	...
      }
      if ((beganInPhase == Bridge.PortletPhase.ACTION_PHASE) || (beganInPhase == Bridge.PortletPhase.EVENT_PHASE) ||
      		(beganInPhase == Bridge.PortletPhase.RESOURCE_PHASE)) {
      	...
      }
      

      So it should be possible to combine them into a single condition block.

      Attachments

        Activity

          People

            neil.griffin Neil Griffin
            neil.griffin Neil Griffin
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Packages

                Version Package
                liferay-faces-2.1.4-ga5
                liferay-faces-2.2.4-ga5
                liferay-faces-3.0.4-legacy-ga5
                liferay-faces-3.0.4-ga5
                liferay-faces-3.1.4-ga5
                liferay-faces-3.2.4-ga5