Uploaded image for project: 'PUBLIC - Liferay Faces'
  1. PUBLIC - Liferay Faces
  2. FACES-1794

The p_o_p_id parameter's value is incorrectly appended to the URL in LiferayURLGeneratorBaseImpl.generateURL().

    Details

      Description

      In LiferayURLGeneratorBaseImpl.generateURL(), the code to add the p_o_p_id parameter to the URL looks like this:

      // Possibly add the p_o_p_id parameter.
      String outerPortletId = parameterMap.get(LiferayConstants.P_O_P_ID);
      
      if (outerPortletId != null) {
          appendParameterToURL(LiferayConstants.P_O_P_ID, parameterValue, url);
      }
      

      parameterValue will contain the value of one of the p_p_col parameters, and not the value of the p_o_p_id parameter.

      To fix this, paramaterValue should be changed to outerPortletId in the above code. The resulting code should look like this:

      // Possibly add the p_o_p_id parameter.
      String outerPortletId = parameterMap.get(LiferayConstants.P_O_P_ID);
      
      if (outerPortletId != null) {
          appendParameterToURL(LiferayConstants.P_O_P_ID, outerPortletId, url);
      }
      

        Attachments

          Activity

            People

            Assignee:
            neil.griffin Neil Griffin
            Reporter:
            kyle.stiemann Kyle Stiemann (Inactive)
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package
                liferay-faces-2.1.4-ga5
                liferay-faces-2.2.4-ga5
                liferay-faces-3.0.4-legacy-ga5
                liferay-faces-3.0.4-ga5
                liferay-faces-3.1.4-ga5
                liferay-faces-3.2.4-ga5