Improve readability of source code by removing dependencies on simple StringPool constants

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: liferay-faces-2.1.4-ga5, liferay-faces-2.2.4-ga5, liferay-faces-3.0.4-legacy-ga5, liferay-faces-3.0.4-ga5, liferay-faces-3.1.4-ga5, liferay-faces-3.2.4-ga5, liferay-faces-4.2.5-ga6
• Fix Version/s: liferay-faces-2.1.5-ga6, liferay-faces-2.2.5-ga6, liferay-faces-3.0.5-legacy-ga6, liferay-faces-3.0.5-ga6, liferay-faces-3.1.5-ga6, liferay-faces-3.2.5-ga6, liferay-faces-4.2.5-ga6
• Component/s: Liferay Faces Alloy / Showcase / Tests, Liferay Faces Bridge Impl / Demos / Tests, Liferay Faces Portal / Demos / Tests, Liferay Faces Util
• Labels: None

The source code for Liferay Faces makes heavy utilization of constants defined in com.liferay.faces.util.StringPool. This is especially true of renderer source code.

This task involves removing dependencies on constants with simple values since there is no PermGen benefit for using these constants, and often times a performance penalty is incurred due to excessive concatenation.

For example, the following code :

responseWriter.write(StringPool.OPEN_PARENTHESIS);
responseWriter.write(StringPool.APOSTROPHE);

Should be changed to:

responseWriter.write("('");