Uploaded image for project: 'PUBLIC - Liferay Faces'
  1. PUBLIC - Liferay Faces
  2. FACES-2330

Delete BridgeExt.BRIDGE_CONTEXT_ATTRIBUTE in the master (4.2.x) branch and move usage to Compat classes in older branches

    Details

      Description

      This task involves removing the following deprecated constant from com.liferay.faces.bridge.internal.BridgeExt in the master (4.2.x) branch:

      @Deprecated
      public static final String BRIDGE_CONTEXT_ATTRIBUTE = "javax.portlet.faces.bridgeContext";
      

      The only usage of this constant is found in the com.liferay.faces.bridge.internal.BridgePhaseBaseImpl class in the init(PortletRequest,PortletResponse,Bridge.PortletPhase) and cleanup() methods. In order to minimize diffs across branches:

      1. In the master (4.2.x) branch, create methods setBridgeContextAttribute(PortletRequest) and removeBridgeContextAttribute(PortletRequest) in the BridgePhaseCompat_1_2_Impl class and have the body of the methods become a no-op comment. The @SuppressWarnings("deprecation") annotation can then be removed from the methods in BridgePhaseBaseImpl.

      2. In older branches, create these methods in the BridgePhaseCompat_1_2_Impl class and move the setAttribute/removeAttribute functionality there, as well as the @SuppressWarnings("deprecation") annotation for each method.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package
                liferay-faces-2.1.5-ga6
                liferay-faces-2.2.5-ga6
                liferay-faces-3.0.5-legacy-ga6
                liferay-faces-3.0.5-ga6
                liferay-faces-3.1.5-ga6
                liferay-faces-3.2.5-ga6
                liferay-faces-4.2.5-ga6