Uploaded image for project: 'PUBLIC - Liferay Faces'
  1. PUBLIC - Liferay Faces
  2. FACES-2462

alloy:dialog is not centered on tablets

    Details

      Description

      {markdown}
      Steps to reproduce:

      1. On a tablet (iPad or Chrome's Nexus 10 emulator should work fine), navigate the the [alloy:dialog general example](http://localhost:8181/showcase-webapp-2.0.0-SNAPSHOT/views/component.faces?componentPrefix=alloy&componentName=dialog&componentUseCase=general).
      2. Click a button to show the dialog.

      If the bug still exists, the dialog will not be centered.

      This bug is caused by the fix for FACES-2450(https://issues.liferay.com/browse/FACES-2450) ([see the fix on github](https://github.com/liferay/liferay-faces-alloy/commit/ab49a99391a34b01c4fa35a781685e8b75984d88)). This is because tablet's are considered mobile by `BrowserSniffer`, and `centered` is set to `false`. [It does not seem possible to detect if a device is a tablet](http://stackoverflow.com/questions/5341637/how-do-detect-android-tablets-in-general-useragent#comment10688630_5344382), so we need to find another way around this. Possibly we should center the dialog ourselves rather than rely on AlloyUI to do so.{markdown}

        Attachments

          Activity

            People

            Assignee:
            kyle.stiemann Kyle Stiemann (Inactive)
            Reporter:
            kyle.stiemann Kyle Stiemann (Inactive)
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package
                alloy-2.0.0
                alloy-3.0.0