Add the private and static modifiers to all inner classes that do not require access to an enclosing instance

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: None
• Fix Version/s: alloy-1.0.0, alloy-2.0.0, alloy-3.0.0, portal-1.0.0, portal-2.0.0, portal-3.0.0, util-1.0.0, util-2.0.0, util-3.0.0, bridge-impl-2.0.0, bridge-impl-3.0.0, metal-1.0.0, bridge-ext-1.0.0, bridge-ext-2.0.0, bridge-ext-3.0.0, bridge-ext-5.0.0, bridge-impl-4.0.0, bridge-impl-5.0.0
• Component/s: Liferay Faces Alloy / Showcase / Tests, Liferay Faces Bridge Ext, Liferay Faces Bridge Impl / Demos / Tests, Liferay Faces Metal / Showcase / Tests, Liferay Faces Portal / Demos / Tests, Liferay Faces Util
• Labels: None

This task involves adding the private and static modifiers to all inner classes (existing in "internal" sub-packages) that do not require access to their enclosing instances. The reason for adding the private modifier is because generally an inner class exists to serve its outer class in some way. The reason for adding the static modifier is because non-static inner classes hold a reference to their enclosing instance which is unnecessary. In addition, when instances of non-static inner classes live longer than their enclosing class instance there is the possibility of a memory leak.

An example of where the static modifier should be added to an inner class is the two inner classes in BodyScriptEncodingResponseWriter.java.