Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
None
-
None
Description
{markdown}
This task involves changing `ProductConstants` to a `enum`. The `enum` should be called `Name` and should be moved into the `Product` interface. Changing to an `enum` will help us to avoid pitfalls with changing String constant values. [Changing String constant values seems like an implementation detail but is actually a breaking API change due to the fact that Java compilation inlines String constants during compilation.](https://web.liferay.com/community/forums/-/message_boards/message/32606100#_19_message_32621317){markdown}
This task involves changing `ProductConstants` to a `enum`. The `enum` should be called `Name` and should be moved into the `Product` interface. Changing to an `enum` will help us to avoid pitfalls with changing String constant values. [Changing String constant values seems like an implementation detail but is actually a breaking API change due to the fact that Java compilation inlines String constants during compilation.](https://web.liferay.com/community/forums/-/message_boards/message/32606100#_19_message_32621317){markdown}
This improvement and the improvement for FACES-2753 can be made at the same time.