Uploaded image for project: 'PUBLIC - Liferay Faces'
  1. PUBLIC - Liferay Faces
  2. FACES-2785

Remove internal factories from faces-config.xml files

Details

    Description

      This task involves removing internal factories (which were once part of the API) from the faces-config.xml files. In order to do this, abstract base Factory classes must be refactored into interfaces. Then new factory implementations must be used directly instead of BridgeFactoryFinder. For an example, see RichTextFactory. Here is a list of the internal factories in bridge-impl:

      • com.liferay.faces.bridge.application.view.internal.BridgeWriteBehindSupportFactory
      • com.liferay.faces.bridge.bean.internal.BeanManagerFactory
      • com.liferay.faces.bridge.bean.internal.PreDestroyInvokerFactory
      • com.liferay.faces.bridge.context.map.internal.ContextMapFactory
      • com.liferay.faces.bridge.internal.BridgeURIFactory
      • com.liferay.faces.bridge.scope.internal.BridgeRequestScopeCacheFactory
      • com.liferay.faces.bridge.scope.internal.BridgeRequestScopeFactory
      • com.liferay.faces.bridge.scope.internal.BridgeRequestScopeManagerFactory
      • com.liferay.faces.bridge.ext.filter.internal.LiferayURLFactory (in bridge-ext)

      Corresponding Wrapper classes are to be deleted as well since they are not usable. For example:

      • com.liferay.faces.bridge.bean.internal.BeanManagerWrapper

      FACES-2736, FACES-2783, and FACES-2784 indicate that some factories may have been recently moved out of the Bridge API and into the Bridge Impl., so those factories would need to be fixed as well.

      Attachments

        Activity

          People

            neil.griffin Neil Griffin
            kyle.stiemann Kyle Stiemann (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:

              Packages

                Version Package
                bridge-ext-5.1.2
                bridge-impl-4.3.1