Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
util-1.0.0, util-2.0.0, util-3.0.0, bridge-impl-2.0.0, bridge-impl-3.0.0, bridge-impl-4.0.0, bridge-impl-5.0.0, bridge-impl-6.0.0
-
None
Description
{markdown}
`BrowserSniffer` is used to detect various aspects of the browser viewing the application. It was originally based on the [BrowserSniffer from Liferay Portal 6.2](https://github.com/liferay/liferay-portal/blob/6.2.5-ga6/portal-service/src/com/liferay/portal/kernel/servlet/BrowserSniffer.java). However, in Liferay 7, certain methods have been removed from the [BrowserSniffer](https://github.com/liferay/liferay-portal/blob/7.0.0-ga1/portal-kernel/src/com/liferay/portal/kernel/servlet/BrowserSniffer.java):{markdown}
{markdown}
Liferay Faces Util's `BrowserSniffer` should be consistent with Liferay 7's `BrowserSniffer`, so the following methods should be removed:
- `isWapXhtml()`
- `isWebKit()`
- `isWml()`{markdown}
`BrowserSniffer` is used to detect various aspects of the browser viewing the application. It was originally based on the [BrowserSniffer from Liferay Portal 6.2](https://github.com/liferay/liferay-portal/blob/6.2.5-ga6/portal-service/src/com/liferay/portal/kernel/servlet/BrowserSniffer.java). However, in Liferay 7, certain methods have been removed from the [BrowserSniffer](https://github.com/liferay/liferay-portal/blob/7.0.0-ga1/portal-kernel/src/com/liferay/portal/kernel/servlet/BrowserSniffer.java):{markdown}
--- 6_2_BrowserSniffer.java 2016-07-06 12:23:15.000000000 -0400 +++ 7_0_BrowserSniffer.java 2016-07-06 12:23:53.000000000 -0400 @@ -73,14 +73,8 @@ public boolean isSun(HttpServletRequest request); - public boolean isWap(HttpServletRequest request); - - public boolean isWapXhtml(HttpServletRequest request); - public boolean isWebKit(HttpServletRequest request); public boolean isWindows(HttpServletRequest request); - public boolean isWml(HttpServletRequest request); - } \ No newline at end of file
Liferay Faces Util's `BrowserSniffer` should be consistent with Liferay 7's `BrowserSniffer`, so the following methods should be removed:
- `isWapXhtml()`
- `isWebKit()`
- `isWml()`{markdown}