-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Won't Fix
-
Affects Version/s: bridge-impl-2.0.0, bridge-impl-3.0.0, bridge-impl-4.0.0
-
Fix Version/s: bridge-impl-2.1.0, bridge-impl-3.1.0, bridge-impl-4.1.0
-
Component/s: Liferay Faces Bridge Impl / Demos / Tests
-
Labels:None
The ResourceImpl.toRequestPath() method contains the following code:
// In order to have Mojarra's ScriptRenderer and StylesheetRenderer function properly, this method first encodes // the URL returned by the wrapped resource. return facesContext.getExternalContext().encodeResourceURL(wrappedRequestPath);
The comment implies that Mojarra's ScriptRenderer and StylesheetRenderer do not call ExternalContext.encodeResourceURL(String) with the result of calling Resource.toRequestPath(). However, the ScriptRenderer.java class in Mojarra 2.1.29-08 and the ScriptRenderer.java class in Mojarra 2.2.13 both do the encoding.
It is therefore unnecessary and incorrect for ResourceImpl.toRequestPath() to encode the return value.