Uploaded image for project: 'PUBLIC - Liferay Faces'
  1. PUBLIC - Liferay Faces
  2. FACES-2986

Necessary fields are not required in jsf-flows-portlet flight.xhtml and checkout.xhtml

    Details

      Description

      In the jsf-flows-portlet checkout.xhtml and flight.xhtml all the fields should be required (except "Address Line 2" in checkout.xhtml). Some of the fields erroneously have the required="true" attribute applied to the surrounding alloy:field rather than the h:inputText (or other input or select component). That attribute should be moved from the alloy:field to the input or select component it contains. The jsf-flows-portlet test should also be modified to fill out all the required fields for both views.

      As part of this issue, some other minor cleanup should be done such as removing the ui:remove elements from the views, ensuring that the submit buttons also render the whole form (render="@form"), and migrating from the deprecated javax.faces.bean.ApplicationScoped to javax.enterprise.context.ApplicationScoped in CustomerServiceMockImpl.java.

        Activity

        Hide
        kyle.stiemann Kyle Stiemann added a comment - - edited

        Philip White, I made some of the changes already. Specifically I've fixed checkout.xhtml and CustomerServiceMockImpl.java. You can grab this diff and apply it:

        curl -o jsf-flows-required-WIP-FACES-2986.diff https://gist.githubusercontent.com/stiemannkj1/24288b448c81234a18a18b84b8e76d63/raw/0922fc813c759db59a47260ae9aa7f4b31d1ae33/jsf-flows-required-WIP-FACES-2986.diff
        git apply jsf-flows-required-WIP-FACES-2986.diff
        

        Please make sure my changes are correct and complete for checkout.xhtml and CustomerServiceMockImpl.java (I think I may have missed some required attrs.), and then fix flight.xhtml and the tester yourself.

        Show
        kyle.stiemann Kyle Stiemann added a comment - - edited Philip White , I made some of the changes already. Specifically I've fixed checkout.xhtml and CustomerServiceMockImpl.java . You can grab this diff and apply it: curl -o jsf-flows-required-WIP-FACES-2986.diff https: //gist.githubusercontent.com/stiemannkj1/24288b448c81234a18a18b84b8e76d63/raw/0922fc813c759db59a47260ae9aa7f4b31d1ae33/jsf-flows-required-WIP-FACES-2986.diff git apply jsf-flows-required-WIP-FACES-2986.diff Please make sure my changes are correct and complete for checkout.xhtml and CustomerServiceMockImpl.java (I think I may have missed some required attrs.), and then fix flight.xhtml and the tester yourself.

          People

          • Assignee:
            kyle.stiemann Kyle Stiemann
            Reporter:
            kyle.stiemann Kyle Stiemann
            Participants of an Issue:
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Subcomponents