-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: facesbridge-tck-2.0.0, facesbridge-tck-3.0.0, facesbridge-tck-4.0.0
-
Fix Version/s: facesbridge-tck-2.1.0, facesbridge-tck-3.1.0, facesbridge-tck-4.1.0
-
Component/s: FacesBridge TCK
-
Labels:None
This issue serves as an improvement task for refactoring the Bridge TCK:
- Rename TestRunnerBean.java -> TestBean.java
- Rename variable ctx -> facesContext
- Rename variable extCtx -> externalContext
- Rename variable ctx -> portletContext
- Rename variable viewRoot -> uiViewRoot
- Rename variable vh -> viewHandler
- Rename variable pReq -> portletRequest
- Rename variable pVal -> paramValue
- Rename variable session -> portletSession
- Rename variable ws -> windowState
- Rename variable mode -> portletMode
- Rename variable response -> stateAwareResponse
- Rename variable m -> requestMap
- Rename variable m -> sessionMap
- Rename variable m -> requestParameterMap
- Rename variable e -> phaseEvent
- Rename variable out -> responsePrintWriter
- Rename variable stream -> inputStream
- New module: bridge-tck-encode-url-tests
Extract encodeActionURL*Test from Tests.java -> EncodeActionURLTests.java
Extract encodeResourceURL*Test from Tests.java -> EncodeResourceURLTests.java
Extract encodeURLEscapingTest from Tests.java -> EncodeURLEscapingTests.java - Rename com.liferay.faces.bridge.tck.tests.chapter_5.section_5_2.TestEventHandler -> Ch5TestEventHandler
- Rename com.liferay.faces.bridge.tck.tests.chapter_6.section_6_1_3_1.TestEventHandler -> Ch6TestEventHandler
- Favor BridgeUtil.getPortletRequestPhase(FacesContext) over BridgeUtil.getPortletRequestPhase()