Uploaded image for project: 'PUBLIC - Liferay Faces'
  1. PUBLIC - Liferay Faces
  2. FACES-3087

Bridge unnecessarily creates a FacesContext during the EVENT_PHASE of the portlet lifecycle

    Details

      Description

      The BridgePhaseEventImpl class should only create a FacesContext thread local singleton when a BridgeEventHandler is registered.

      This bug was discovered after FACES-3039 was fixed. Specifically, FacesBridge TCK TestPage065 (eventNoHandlerPRPPreservedTest) was failing in the liferay-faces-bridge-impl.git 2.x branch because Trinidad 1.2.13 was setting a request attribute named "org.apache.myfaces.trinidad.util.RequestStateMap" in the EVENT_PHASE of the portlet lifecycle, simply because the FacesContext was being initialized. The presence of the request attribute caused the subsequent RENDER_PHASE to throw NullPointerException in Trinidad, which in turn caused the test to fail.

        Attachments

          Activity

            People

            Assignee:
            neil.griffin Neil Griffin
            Reporter:
            neil.griffin Neil Griffin
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package
                bridge-impl-2.1.0
                bridge-impl-3.1.0
                bridge-impl-4.1.0