Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2.0
    • Component/s: None
    • Labels:
      None
    • Similar Issues:
      Show 5 results 

      Description

      • Basic support for markup and service description services.
      • admin portlet for managing producers
      • consumer portlet to consume remote portlets

        Activity

        Hide
        Brian Chan added a comment - - Restricted to

        Hi Rajesh,

        I had to roll this back because of:

        1.) Broke Hudson, see http://hudson.liferay.com/job/portal_trunk/119/

        2.) Broke Eclipse

        3.) Broke Ant (can't compile)

        4.) Broke JSP precompiler

        Show
        Brian Chan added a comment - - Restricted to Hi Rajesh, I had to roll this back because of: 1.) Broke Hudson, see http://hudson.liferay.com/job/portal_trunk/119/ 2.) Broke Eclipse 3.) Broke Ant (can't compile) 4.) Broke JSP precompiler
        Hide
        Brian Chan added a comment -

        Also, is there a way to add this feature without modifying the Tomcat installation process?

        Show
        Brian Chan added a comment - Also, is there a way to add this feature without modifying the Tomcat installation process?
        Hide
        Brian Chan added a comment - - Restricted to

        Hi Rajesh,

        Can you recheck it in. I rolled it because you didn't run "ant format-source" before checking it in and becaue of that, Neelan later ran it and checked in stuff that was really your changes (rev 18790).

        Also, it still breaks on Eclipse.

        Show
        Brian Chan added a comment - - Restricted to Hi Rajesh, Can you recheck it in. I rolled it because you didn't run "ant format-source" before checking it in and becaue of that, Neelan later ran it and checked in stuff that was really your changes (rev 18790). Also, it still breaks on Eclipse.
        Hide
        Jesper We added a comment - - Restricted to

        The portal crashes at startup if relative pathnames are used in app.server.properties with this checkin.
        The code in WSRPPersistenceHelper.java looks weird.

        Show
        Jesper We added a comment - - Restricted to The portal crashes at startup if relative pathnames are used in app.server.properties with this checkin. The code in WSRPPersistenceHelper.java looks weird.
        Hide
        Brian Chan added a comment - - Restricted to

        Hi Rajesh,

        Thanks for the help with WSRP. I've only refactored the backend so far. I'll be doing the front end tomorrow.

        Please see a diff of revision 18919 so you can see the refactoring and source formatting that I did.

        Here's what I did...

        1.) I refactored code to make it cleaner and more streamlined.

        2.) SVN was broken for Eclipse and for the extension environment (I fixed it)

        3.) I reverted the changes to catalina.properties.* (I don't understand why we need to modify Tomcat)

        4.) I reverted most of the changes to build.xml because it's not really needed. We should be able to do this programmatically at startup instead of at deploy time.

        But to be able to do it at startup time, I'll need you to move the settings in wsrpconfig.properties to portal.properties, and also expose WSRPConfig.java with a bunch of setters.

        First, add setters to WSRPConfig.java. Then, make WSRPConfig.java lazy (don't read the wsrpconfig.properties if setters are called). This will allow me to manually set them from portal.properties.

        5.) There are also some properties in wsrpconfig.properties that don't make sense to me, like:

        portletcontainer.uri=/portletdriver

        and

        wsrpdriver.uri=/web/guest/home

        Can you review them and remove the ones that aren't needed?

        6.) Can you blog about the work you've done and teach ppl in that blog how to use the portlet? It's ok if the UI is ugly for now (colors don't match), because after you blog, and after I've refactored the front end code, another UI team from Liferay will make it pretty.

        Show
        Brian Chan added a comment - - Restricted to Hi Rajesh, Thanks for the help with WSRP. I've only refactored the backend so far. I'll be doing the front end tomorrow. Please see a diff of revision 18919 so you can see the refactoring and source formatting that I did. Here's what I did... 1.) I refactored code to make it cleaner and more streamlined. 2.) SVN was broken for Eclipse and for the extension environment (I fixed it) 3.) I reverted the changes to catalina.properties.* (I don't understand why we need to modify Tomcat) 4.) I reverted most of the changes to build.xml because it's not really needed. We should be able to do this programmatically at startup instead of at deploy time. But to be able to do it at startup time, I'll need you to move the settings in wsrpconfig.properties to portal.properties, and also expose WSRPConfig.java with a bunch of setters. First, add setters to WSRPConfig.java. Then, make WSRPConfig.java lazy (don't read the wsrpconfig.properties if setters are called). This will allow me to manually set them from portal.properties. 5.) There are also some properties in wsrpconfig.properties that don't make sense to me, like: portletcontainer.uri=/portletdriver and wsrpdriver.uri=/web/guest/home Can you review them and remove the ones that aren't needed? 6.) Can you blog about the work you've done and teach ppl in that blog how to use the portlet? It's ok if the UI is ugly for now (colors don't match), because after you blog, and after I've refactored the front end code, another UI team from Liferay will make it pretty.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Structure Helper Panel