Thanks for the help with WSRP. I've only refactored the backend so far. I'll be doing the front end tomorrow.
Please see a diff of revision 18919 so you can see the refactoring and source formatting that I did.
Here's what I did...
1.) I refactored code to make it cleaner and more streamlined.
2.) SVN was broken for Eclipse and for the extension environment (I fixed it)
3.) I reverted the changes to catalina.properties.* (I don't understand why we need to modify Tomcat)
4.) I reverted most of the changes to build.xml because it's not really needed. We should be able to do this programmatically at startup instead of at deploy time.
But to be able to do it at startup time, I'll need you to move the settings in wsrpconfig.properties to portal.properties, and also expose WSRPConfig.java with a bunch of setters.
First, add setters to WSRPConfig.java. Then, make WSRPConfig.java lazy (don't read the wsrpconfig.properties if setters are called). This will allow me to manually set them from portal.properties.
5.) There are also some properties in wsrpconfig.properties that don't make sense to me, like:
Can you review them and remove the ones that aren't needed?
6.) Can you blog about the work you've done and teach ppl in that blog how to use the portlet? It's ok if the UI is ugly for now (colors don't match), because after you blog, and after I've refactored the front end code, another UI team from Liferay will make it pretty.