Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-100230

Move all .js-containing modules to liferay-npm-scripts

    Details

    • Type: Task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      We just noticed that contacts-web contains .js files but doesn't have a package.json file, which means that it isn't using liferay-npm-scripts to build, which means that Babel isn't transpiling anything, which means it is a foot-gun waiting for somebody to add an arrow function...

      Julien Castelain is going to add a package.json to the build in that module, but we should do a sweep to find any others like this: basically anything with "modules/apps/foo/bar/src/" that contains ".js" but doesn't have a package.json.

        Attachments

          Activity

            People

            • Assignee:
              support-lep@liferay.com SE Support
              Reporter:
              greg.hurrell Greg Hurrell
              Recent user:
              Greg Hurrell
              Participants of an Issue:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Packages

                Version Package