Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-100464

Review internal structure of frontend-js-web module

    Details

    • Type: Task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      We currently have some excessive nesting in the frontend-js-web module. Most notable is that we have a number of folders that have been created which contain only a single file, which doesn't make a lot of sense: folders are for organizing groups of files, but if you place a single file into a folder, you haven't actually reduced clutter — you've just added an unnecessary layer of indirection.

      Example tree view:

      https://gist.github.com/wincent/a7ec2cbc09d71f0fd756e7dd8280cfd3

      There you can see these files that live in alone in their folders:

      • liferay/aop/AOP.es.js
      • liferay/debounce/debounce.es.js
      • liferay/keyboard-focus/KeyboardFocusManager.es.js
      • liferay/modal/commands/OpenSimpleInputModal.es.js
      • liferay/toast/commands/OpenToast.es.js

      At least some of those probably don't deserve to be in folders of their own, so we should review the contents of this module for possible organizational improvements — including but not necessarily limited to the question of files that live alone in folders — (with the obvious proviso that we need to be careful to check for consumers that may be accessing the module contents via an explicit deep path as opposed to grabbing exported items from the index).

        Attachments

          Activity

            People

            • Assignee:
              support-lep@liferay.com SE Support
              Reporter:
              greg.hurrell Greg Hurrell
              Recent user:
              Greg Hurrell
              Participants of an Issue:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Packages

                Version Package