-
Type:
Task
-
Status: Closed
-
Priority:
Minor
-
Resolution: Completed
-
Affects Version/s: None
-
Fix Version/s: 7.2.10 DXP FP4, Master
-
Component/s: Web Search > Search Admin
-
Labels:
-
Branch Version/s:7.2.x
-
Backported to Branch:Committed
-
Story Points:2
-
Sprint:Search | S03 Sprint 8
-
Git Pull Request:
From https://github.com/brianchandotcom/liferay-portal-ee/pull/26423#discussion_r322099323, we shouldn't be using console.log, but instead possibly console.error.
A ticket in the frontend-guidelines repo has been opened to discuss an appropriate pattern for displaying messages in the console so we should wait to see what is decided and update accordingly. https://github.com/liferay/liferay-frontend-guidelines/issues/84
Changes made in this ticket:
- Added more error boundaries so if certain parts of the react app break, only parts of the app will not appear, rather than the entire page going blank
- An empty state image with an error message will appear if the entire app breaks (due to a javascript error) "An error has occurred and we were unable to load Result Rankings."
- If NODE_ENV=development, error messages will be logged to the browser console and a debugger for the form will be displayed to reveal the form values being submitted.