Details

    • Type: Task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      See Brian's comment here: https://github.com/brianchandotcom/liferay-portal/pull/78396#issuecomment-531866390

      In practice, I think we shouldn't prioritize this until we see people doing it — if nothing else because there is nothing to stop somebody from creating an equivalent hook with a diffrent name — but one factor which might drive us to do this sooner is catching the anti-pattern of doing setState calls inside async methods (fetch callbacks and other promise then-ables etc). If we can catch that (an actual source of bugs) and direct them to use useIfMounted(), that would be fantastic.

        Attachments

          Activity

            People

            • Assignee:
              support-lep@liferay.com SE Support
              Reporter:
              greg.hurrell Greg Hurrell
              Recent user:
              Greg Hurrell
              Participants of an Issue:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Packages

                Version Package