Unable to parse version of user-agent where the version is at the end of the string and only contains a major version

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, 7.1.X, 7.2.X, Master
• Fix Version/s: 7.0.0 DXP FP89, 7.0.10.13 DXP SP13, 7.0.X, 7.1.10 DXP FP16, 7.1.X, 7.2.10 DXP FP4, 7.2.1 CE GA2, 7.2.X, 7.3.10 DXP GA1, Master
• Component/s: ~ [Archived] Frontend Infrastructure
• Labels:
  • ee-ts
  • liferay-dxp-70-sp13
  • liferay-fixpack-de-89-7010
  • liferay-fixpack-dxp-16-7110
  • liferay-fixpack-dxp-4-7210
• Branch Version/s:
  7.2.x, 7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/79681

Steps to Reproduce

1. Start the portal
2. Send a request to the portal with a user-agent string of the following (through Postman or something similar):

Mozilla/5.0 (iPhone; CPU iPhone OS 13_0 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148 Safari IPhoneAppVersion/2.6.87 IPhoneWebkitWrapper BillingSupported iphoneAppVersion/2.6.87 rv:1

Expected Results
There are no errors in the logs.

Actual Results
The following error appears in the logs:

2019-10-14 18:41:23.373 ERROR [http-nio-8080-exec-2][IncludeTag:128] Current URL / generates exception: String index out of range: 206
java.lang.StringIndexOutOfBoundsException: String index out of range: 206
	at java.lang.String.charAt(String.java:658)
	at com.liferay.portal.servlet.BrowserSnifferImpl.parseVersion(BrowserSnifferImpl.java:328)
	at com.liferay.portal.servlet.BrowserSnifferImpl.getRevision(BrowserSnifferImpl.java:88)
	at com.liferay.portal.kernel.servlet.BrowserSnifferUtil.getRevision(BrowserSnifferUtil.java:50)
	at org.apache.jsp.html.common.themes.top_005fhead_jsp._jspService(top_005fhead_jsp.java:1006)
	at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
	at com.liferay.portal.servlet.DirectRequestDispatcher.include(DirectRequestDispatcher.java:64)
	at com.liferay.portal.servlet.DirectRequestDispatcherFactoryImpl$IndirectRequestDispatcher.include(DirectRequestDispatcherFactoryImpl.java:199)
	at com.liferay.portal.servlet.ClassLoaderRequestDispatcherWrapper.doDispatch(ClassLoaderRequestDispatcherWrapper.java:79)
	at com.liferay.portal.servlet.ClassLoaderRequestDispatcherWrapper.include(ClassLoaderRequestDispatcherWrapper.java:53)
	at com.liferay.taglib.util.IncludeTag.includePage(IncludeTag.java:398)
	at com.liferay.taglib.util.IncludeTag.include(IncludeTag.java:374)
	at com.liferay.taglib.util.IncludeTag.doInclude(IncludeTag.java:217)
	at com.liferay.taglib.util.IncludeTag.doEndTag(IncludeTag.java:88)
	at freemarker.ext.jsp.TagTransformModel$TagWriter.endEvaluation(TagTransformModel.java:400)
	at freemarker.ext.jsp.TagTransformModel$TagWriter.afterBody(TagTransformModel.java:388)
	at freemarker.core.Environment.visitAndTransform(Environment.java:427)
	at freemarker.core.UnifiedCall.accept(UnifiedCall.java:107)
	at freemarker.core.Environment.visit(Environment.java:324)