Details
-
Story
-
Status: Closed
-
Minor
-
Resolution: Completed
-
None
-
TANGO | SP_23 | Oct30-Nov13, TANGO | SP_24 | Nov13-Nov27, TANGO | SP_25 | Nov27-Dec11
Description
Motivation
According to the data obtained by Usability Tests, some users didn't make any change in the variants which can effect in a non-profitable test run. Let's provide them more information to at least let them know that they don't have a variant or that their variants do not have changes.
To solve this, the button "Review and Run" should be not disabled so as to let them click it and provide them with information after the validation for no variants and no element select as click goal.
Scope
Winner Variant is resolved in LPS-103752, so it is not part of this story.
Design
Acceptance Criteria
No Variants
- Given an AB Test with no variants (except from Control)
- When clicking "Review and Run" button
- Then an error alert and an inline validation appear
No Variants and No Element set as click goal
- Given an AB Test with no variants (except from Control) and click goal without element selected
- When clicking "Review and Run" button
- Then a summary alert with both alerts appear and an inline validation per each error appear too.
Test Scenarios
AC ID | Test Strategy | Test Scenarios | Is it covered by FrontEnd ? (JS-Unit) | Is it covered by BackEnd ? (unit or integration) |
---|---|---|---|---|
01 | Regression | Validate if the error/validation message appears when the user tries to run an AB test only with the control variant | YES | YES |
02 | Smoke | Validate if the error/validation message appears when the user tries to run an AB test with the element not set (for clickable type) | YES | YES |
Frontend tests added here: https://github.com/brianchandotcom/liferay-portal/pull/80939/commits/4ce8456b30eb469f703c062b52e91045b484164b
Backend tests added here: https://github.com/epgarcia/liferay-portal/pull/987/commits/87ecc894411e7a05c1b99cd6d72f25633eb8b750