Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Completed
    • Affects Version/s: None
    • Fix Version/s: Master
    • Labels:
      None

      Description

      As of https://github.com/liferay/eslint-config-liferay/pull/79 we activated the "no-console" rule, allowing use of "console.warn" and "console.error" as exceptions. There are a few places in liferay-portal where we have unnecessary suppression (because they relate to "warn" or "error" calls, or because they use "log" calls that really should be "error").

      Additionally, we published guidelines at https://github.com/liferay/liferay-frontend-guidelines/blob/c1f6e942ed19b89dae6be977cdb46a5bc9fb18ae/dxp/debugging.md that advise to minimize the use of logging outside of development environment, so there is at least one place where a log call should be moved inside an appropriate guard check.

        Attachments

          Activity

            People

            • Assignee:
              brian.chan Brian Chan
              Reporter:
              greg.hurrell Greg Hurrell
              Recent user:
              Brian Chan
              Participants of an Issue:
              Engineering Assignee:
              Greg Hurrell
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package
                Master