Upgrade fails on Sybase 16

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 7.3.0 CE GA1, 7.3.10 DXP GA1, Master
• Component/s: Core Infrastructure > Database Access
• Labels:
  • pt-upgrade-review
• Fix Priority: 4
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/81535
• Bug Type: Regression Bug

Steps to Reproduce:

1. Start 7.0 with Sybase 16. After start successful, shut down the server.
2. Upgrade to master.

Expected Results:
Upgrade should success without any error.

Actual Results:
Below error is thrown:

2019-11-28 13:28:22.913 INFO  [main][UpgradeProcess:107] Failed upgrade process com.liferay.portal.upgrade.PortalUpgradeProcess in 1149741 ms
com.liferay.portal.kernel.upgrade.UpgradeException: com.liferay.portal.kernel.upgrade.UpgradeException: com.sybase.jdbc4.jdbc.SybSQLException: Incorrect syntax near 'AssetCategory'.

        at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:101)
        at com.liferay.portal.kernel.upgrade.util.UpgradeProcessUtil._upgradeProcess(UpgradeProcessUtil.java:173)
        at com.liferay.portal.kernel.upgrade.util.UpgradeProcessUtil.upgradeProcess(UpgradeProcessUtil.java:140)
        at com.liferay.portal.kernel.upgrade.util.UpgradeProcessUtil.upgradeProcess(UpgradeProcessUtil.java:122)
        at com.liferay.portal.events.StartupHelperUtil.upgradeProcess(StartupHelperUtil.java:151)
        at com.liferay.portal.tools.DBUpgrader.upgrade(DBUpgrader.java:183)
        at com.liferay.portal.tools.DBUpgrader.main(DBUpgrader.java:109)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at com.liferay.portal.tools.db.upgrade.client.DBUpgraderLauncher.main(DBUpgraderLauncher.java:55)
Caused by: com.liferay.portal.kernel.upgrade.UpgradeException: com.sybase.jdbc4.jdbc.SybSQLException: Incorrect syntax near 'AssetCategory'.

        at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:101)
        at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:123)
        at com.liferay.portal.upgrade.PortalUpgradeProcess.doUpgrade(PortalUpgradeProcess.java:129)
        at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:96)
        ... 11 more
Caused by: com.sybase.jdbc4.jdbc.SybSQLException: Incorrect syntax near 'AssetCategory'.

        at com.sybase.jdbc4.tds.Tds.processEed(Tds.java:4131)
        at com.sybase.jdbc4.tds.Tds.nextResult(Tds.java:3247)
        at com.sybase.jdbc4.jdbc.ResultGetter.nextResult(ResultGetter.java:78)
        at com.sybase.jdbc4.jdbc.SybStatement.nextResult(SybStatement.java:294)
        at com.sybase.jdbc4.jdbc.SybStatement.nextResult(SybStatement.java:276)
        at com.sybase.jdbc4.jdbc.SybStatement.updateLoop(SybStatement.java:2749)
        at com.sybase.jdbc4.jdbc.SybStatement.executeUpdate(SybStatement.java:2733)
        at com.sybase.jdbc4.jdbc.SybStatement.executeUpdate(SybStatement.java:588)
        at com.zaxxer.hikari.pool.ProxyStatement.executeUpdate(ProxyStatement.java:117)
        at com.zaxxer.hikari.pool.HikariProxyStatement.executeUpdate(HikariProxyStatement.java)
        at com.liferay.portal.dao.db.BaseDB.runSQL(BaseDB.java:349)
        at com.liferay.portal.dao.db.BaseDB.runSQL(BaseDB.java:315)
        at com.liferay.portal.kernel.dao.db.BaseDBProcess.runSQL(BaseDBProcess.java:66)
        at com.liferay.portal.kernel.upgrade.UpgradeCTModel._upgradeCTModel(UpgradeCTModel.java:128)
        at com.liferay.portal.kernel.upgrade.UpgradeCTModel.doUpgrade(UpgradeCTModel.java:51)
        at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:96)
        ... 14 more

Reproduced on:
Tomcat 9.0.17 + Sybase16. Portal master GIT ID: 6db75964492e75ae4b717b17526dfaf3b73c26bb.

Note:
The issue is blocked by LPS-105037 and it is only be reproduced on master.