Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-105554

FontAwesomeTopHeadInclude contains an extra script tag and an unclosed link tag

Details

    Description

      Reproduction steps

      1. Start a master vanilla bundle
      2. Enabling Font Awesome at Control Panel → Configuration → System Settings and select Third Party under the PLATFORM
      3. Checj the HTML source of the Home page __ 

      Actual Result

      <link charset="utf-8" data-senna-track="permanent" href="/o/frontend-theme-font-awesome-web/css/main.css" rel="stylesheet"></script>

      Expected Result: 

      <link charset="utf-8" data-senna-track="permanent" href="/o/frontend-theme-font-awesome-web/css/main.css" rel="stylesheet" type="text/css" />

       Reproduced on master

      https://github.com/liferay/liferay-portal/blob/master/modules/apps/frontend-theme/frontend-theme-font-awesome-web/src/main/java/com/liferay/frontend/theme/font/awesome/web/internal/servlet/taglib/FontAwesomeTopHeadDynamicInclude.java

      Attachments

        Activity

          People

            summer.zhang Summer Zhang
            roland.pakai Roland Pákai
            Kiyoshi Lee Kiyoshi Lee
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              2 years, 49 weeks, 6 days ago

              Packages

                Version Package
                7.2.10 DXP FP4
                7.2.X
                7.3.0 CE GA1
                7.3.10 DXP GA1
                Master