isGroupAdmin() checks for a non-existent groupId attribute in the SearchContext

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.2.X, Master
• Fix Version/s: 7.2.10 DXP FP5, 7.2.10.2 DXP SP2, 7.2.X, 7.3.0 CE GA1, 7.3.1 CE GA2, 7.3.10 DXP GA1, Master
• Component/s: User Management
• Labels:
  • INACTIVE
  • ee-ts
  • liferay-dxp-72-sp2
  • liferay-fixpack-dxp-5-7210
• Branch Version/s:
  7.2.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Sprint: U&SM| S03 Sprint15| 1.21-2.4
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/83024

Repro Steps

1. Create 25,000+ users by navigating to Configuration > Server Administration > Script and executing the attached Groovy script. This will take 1-2 hours.
2. Create a new user and add it to the default site as a Site Administrator
3. Log in as the new user
4. Navigate to Site Administration > People > Members > Add

Results

Expected Result: Users will be displayed correctly without performance issues
Actual Result: Only the newly created Site Administrator is displayed after 1-2 minutes

Additional Notes

The performance hit is due to the users being filtered. As a Site Administrator, this step is unnecessary. There is an isGroupAdmin() check to prevent this, but the SearchContext it operates on is missing a groupId attribute to indicate Site Administrator privileges.