Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-106239

serviceContext.getCommand() needs to be set in any calls to WikiPageLocalServiceImpl._startWorkflowInstance since any *MapBuilders cannot have null values

    Details

    • Story Points:
      5
    • Fix Priority:
      5
    • Sprint:
      Infra QA Sprint 12

      Description

      Example failing modules integration test:

      com.liferay.wiki.uad.display.test.WikiPageUADDisplayTest.testCount

      java.lang.NullPointerException
      	at com.liferay.portal.kernel.util.BaseMapWrapper.doPut(BaseMapWrapper.java:115)
      	at com.liferay.portal.kernel.util.HashMapBuilder$HashMapWrapper.put(HashMapBuilder.java:90)
      	at com.liferay.portal.kernel.util.HashMapBuilder.put(HashMapBuilder.java:45)
      	at com.liferay.wiki.service.impl.WikiPageLocalServiceImpl._startWorkflowInstance(WikiPageLocalServiceImpl.java:3191)
      	at com.liferay.wiki.service.impl.WikiPageLocalServiceImpl.addPage(WikiPageLocalServiceImpl.java:265)
      	at com.liferay.wiki.service.impl.WikiPageLocalServiceImpl.addPage(WikiPageLocalServiceImpl.java:293)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:498)
      	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
      	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
      	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
      	at com.liferay.portal.service.ServiceContextAdvice.invoke(ServiceContextAdvice.java:60)
      	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
      	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
      	at com.sun.proxy.$Proxy713.addPage(Unknown Source)
      	at com.liferay.wiki.uad.test.WikiPageUADTestHelper.addWikiPage(WikiPageUADTestHelper.java:51)
      	at com.liferay.wiki.uad.display.test.WikiPageUADDisplayTest.addBaseModel(WikiPageUADDisplayTest.java:53)
      	at com.liferay.wiki.uad.display.test.WikiPageUADDisplayTest.addBaseModel(WikiPageUADDisplayTest.java:38)
      	at com.liferay.user.associated.data.test.util.BaseUADDisplayTestCase.testCount(BaseUADDisplayTestCase.java:48)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:498)
      	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$2.evaluate(TestExecutorRunnable.java:234)
      	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
      	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
      	at com.liferay.portal.kernel.test.rule.TimeoutTestRule$1.evaluate(TimeoutTestRule.java:89)
      	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
      	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$1.evaluate(TestExecutorRunnable.java:143)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$1.evaluate(AbstractTestRule.java:59)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$1.evaluate(AbstractTestRule.java:59)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$1.evaluate(AbstractTestRule.java:59)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$1.evaluate(AbstractTestRule.java:59)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$1.evaluate(AbstractTestRule.java:59)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$1.evaluate(AbstractTestRule.java:59)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$1.evaluate(AbstractTestRule.java:59)
      	at com.liferay.portal.kernel.test.rule.AbstractTestRule$1.evaluate(AbstractTestRule.java:59)
      	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
      	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable._execute(TestExecutorRunnable.java:181)
      	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable.run(TestExecutorRunnable.java:95)
      	at java.lang.Thread.run(Thread.java:745)
      

      Full console log:
      https://test-1-1.liferay.com/job/test-portal-acceptance-upstream-batch(master)/41271/AXIS_VARIABLE=43,label_exp=!master/consoleText
      More examples of Wiki tests that are failing upstream:
      https://test-1-1.liferay.com/job/test-portal-acceptance-upstream-batch(master)/41271/#showFailuresLink

      Reproduced on:
      Portal master git commit: 013790a50cbb32218faa89fd071366ed0b8ae0fc

      Not reproducible on:
      Portal master git commit: 143b4452a45b7f058f1d68079a172cecffff5f57

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              linda.sui Linda Sui
              Reporter:
              joshua.chong Joshua Chong
              Participants of an Issue:
              Recent user:
              Jason Pince
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                1 year, 9 weeks ago

                  Packages

                  Version Package
                  7.3.0 CE GA1
                  7.3.10 DXP GA1
                  Master