Details

      Description

      This is a continuation from https://issues.liferay.com/browse/IFI-1331, where we:

      In this task we are going to create a structure that includes admin-header + page-content in all their variants: product-admin-menu, widget-selection-panel, simulation-panel, staging, etc

      The idea is to minimize the usage of classes we are currently adding to the page e.g. `.has-control-menu`, `.product-menu-open`, `open-admin-panel`, `.lfr-has-simulation-panel`, etc

      The findings were collected in this document. The proposal after analyzing everything is to:

      • Leverage new CSS features such as position: sticky
      • Simplify markup 
      • Remove unnecessary height values or height calculations
      • Add additional APIs to make it possible to stack menus in a proper way

      With that in mind, we'd need to:

      • Add position:sticky to the control-menu tag
      • Remove unnecessary css
      • Create a "Menu" API to complement the existing ControlMenuEntry and ControlMenuCategory interfaces that makes it possible to properly stack menus in the control-menu position
      • Update existing "abuses" of the ControlMenuEntry API to use the newly created Menu API
        • Update StagingBar
        • Update VariationsBar
        • Update FragmentsBar
        • Apply it to ChangeListBar

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Packages

                  Version Package
                  Master